[
https://issues.apache.org/jira/browse/PROTON-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367914#comment-17367914
]
Jiri Daněk commented on PROTON-2386:
------------------------------------
Previously, the expired certificates caused silent timeout
(https://github.com/apache/qpid-proton/runs/2587551651#step:14:2770):
{noformat}
30: Test timeout computed to be: 1500
30: test_application_event_no_object_leaks
(test_PROTON_1709_application_event_object_leak.Proton1709Test) ... ok
30: test_sync_request_response_blocking_connection_no_fd_leaks
(test_PROTON_1800_syncrequestresponse_fd_leak.Proton1800Test) ... ok
30: test_send_message_ssl_no_object_leaks
(test_PROTON_2111_container_ssl_ssldomain_object_leak.Proton2111Test)
30/51 Test #30: python-integration-test ..........***Timeout 1500.11 sec
{noformat}
When I reproduced the situation now, I got
{noformat}
12: test_send_message_ssl_no_object_leaks
(test_PROTON_2111_container_ssl_ssldomain_object_leak.Proton2111Test)
12: Starts a broker with ssl acceptor, in a loop connects to it and sends
message. ... ERROR:proton:amqp:connection:framing-error: SSL Failure:
error:1416F086:SSL routines:tls_process_server_certificate:certificate verify
failed
12: ERROR:proton:amqp:connection:framing-error: SSL Failure: Unknown error
{noformat}
and then comes the ctest timeout. So we still don't get a descriptive error
(PROTON-1870), but we do get some error now. The fact the test timeouts is a
property of the test. The only fix I can think of would be to make it timeout
sooner, or try to fail the test on seeing the ssl failure.
> test_send_message_ssl_no_object_leaks should not timeout silently when SSL
> certificate is expired
> -------------------------------------------------------------------------------------------------
>
> Key: PROTON-2386
> URL: https://issues.apache.org/jira/browse/PROTON-2386
> Project: Qpid Proton
> Issue Type: Test
> Components: python-binding
> Affects Versions: proton-c-0.34.0
> Reporter: Jiri Daněk
> Assignee: Jiri Daněk
> Priority: Major
> Fix For: proton-c-0.35.0
>
>
> The expired certificate was fixed in PROTON-2220,
> https://github.com/apache/qpid-proton/pull/314
> Some indication to the person reviewing CI logs should be provided. Test
> should fail with sensible error, preferably.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]