kgiusti commented on a change in pull request #1270:
URL: https://github.com/apache/qpid-dispatch/pull/1270#discussion_r658094095
##########
File path: tests/system_tests_user_id.py
##########
@@ -242,7 +242,7 @@ def create_ssl_domain(self, ssl_options_dict,
mode=SSLDomain.MODE_CLIENT):
domain = SSLDomain(mode)
if trustfile:
domain.set_trusted_ca_db(str(trustfile))
- domain.set_peer_authentication(SSLDomain.VERIFY_PEER,
str(trustfile))
+ domain.set_peer_authentication(SSLDomain.VERIFY_PEER, str(trustfile))
Review comment:
if trustfile is false or None, what does 'str(trustfile)' return?
Should there instead be a "else" to the trustfile test where None is passed as
the second arg to set_peer_authentication?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
