ganeshmurthy commented on a change in pull request #1273:
URL: https://github.com/apache/qpid-dispatch/pull/1273#discussion_r658281530



##########
File path: src/router_node.c
##########
@@ -2108,10 +2112,6 @@ static void CORE_delivery_update(void *context, 
qdr_delivery_t *dlv, uint64_t di
                 // and if it is blocked by Q2 holdoff, get the link rolling 
again.
                 //
                 qd_message_Q2_holdoff_disable(msg);
-
-                qd_link_t_sp *safe_ptr = NEW(qd_link_t_sp);
-                set_safe_ptr_qd_link_t(link, safe_ptr);
-                qd_connection_invoke_deferred(qd_conn, 
deferred_AMQP_rx_handler, safe_ptr);

Review comment:
       So no need to  invoke the deferred_AMQP_rx_handler anymore

##########
File path: src/router_node.c
##########
@@ -2108,10 +2112,6 @@ static void CORE_delivery_update(void *context, 
qdr_delivery_t *dlv, uint64_t di
                 // and if it is blocked by Q2 holdoff, get the link rolling 
again.
                 //
                 qd_message_Q2_holdoff_disable(msg);
-
-                qd_link_t_sp *safe_ptr = NEW(qd_link_t_sp);
-                set_safe_ptr_qd_link_t(link, safe_ptr);
-                qd_connection_invoke_deferred(qd_conn, 
deferred_AMQP_rx_handler, safe_ptr);

Review comment:
       So no need to  invoke the deferred_AMQP_rx_handler anymore ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to