gemmellr commented on pull request #41: URL: https://github.com/apache/qpid-jms/pull/41#issuecomment-869743728
I have pushed an alternative commit https://github.com/apache/qpid-jms/commit/531a48eb4edfb609df6a054d999296e6b65ce53f that implements the functionality in a slightly different way. It keeps the context factory changes a bit simpler and I also ensured the new config route supports the same variable expansion the regular existing connection factory config route does. They will behave the same for the usage the JIRA suggests and your test covered, and I used your test as a basis for the ones added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
