jiridanek commented on a change in pull request #1289: URL: https://github.com/apache/qpid-dispatch/pull/1289#discussion_r666846305
########## File path: tests/system_tests_websockets.py ########## @@ -0,0 +1,62 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License +# + +import unittest + +from system_test import Qdrouterd +from system_test import main_module, TestCase, Process + + +class WebsocketsConsoleTest(TestCase): + """Run websockets tests connecting to the console""" + + @classmethod + def setUpClass(cls): + super().setUpClass() + + cls.http_port = cls.tester.get_port() + + config = [ + ('router', {'mode': 'interior', 'id': 'A'}), + ('listener', {'role': 'normal', 'port': cls.http_port, 'http': True}) + ] + config = Qdrouterd.Config(config) + cls.router: Qdrouterd = cls.tester.qdrouterd('A', config, wait=True, expect=Process.EXIT_OK) + + def test_stopping_broker_while_websocket_is_connected_does_not_crash(self): + """Verify the shutdown sequence works when a client is connected to a websocket port. + + Previously, this was broken in DISPATCH-857, DISPATCH-945, DISPATCH-2098""" + import asyncio + try: + import websockets + except ImportError: + self.skipTest("python test requirement package `websocket` is missing") Review comment: ```suggestion self.skipTest("python test requirement package `websockets` is missing") ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
