ChugR commented on a change in pull request #1197:
URL: https://github.com/apache/qpid-dispatch/pull/1197#discussion_r675623583
##########
File path: tests/system_test.py
##########
@@ -1107,15 +1107,10 @@ def on_accepted(self, event):
event.delivery.settle()
def on_released(self, event):
- # for some reason Proton 'helpfully' calls on_released even though the
- # delivery state is actually MODIFIED
if event.delivery.remote_state == Delivery.MODIFIED:
- return self.on_modified(event)
Review comment:
You know what, I agree with you. Leave it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
