kgiusti commented on pull request #1312: URL: https://github.com/apache/qpid-dispatch/pull/1312#issuecomment-885708751
> Do we need :method and :status as separate properties if they are also conveyed in subject for request and response respectively? @grs you're correct - the app properties are duplicate. However IIUC the HTTP/2 adaptor also puts :method and :status in the app properties BUT doesn't set a Subject property at all. @ganeshmurthy what do you think: in the HTTP/1 adaptor, the AMQP Subject property contains the request method (e.g. GET) in the AMQP mapping for a request method, and sets Subject to the response code (:status, e.g. 200) in the response AMQP message. Should both adaptors remove the :status and :method app properties and just use the Subject field instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
