kgiusti commented on a change in pull request #1301:
URL: https://github.com/apache/qpid-dispatch/pull/1301#discussion_r675789529
##########
File path: src/message.c
##########
@@ -2973,18 +2981,36 @@ bool qd_message_oversize(const qd_message_t *msg)
}
+int qd_message_stream_data_footer_append(qd_message_t *message,
qd_buffer_list_t *footer_props)
+{
+ qd_composed_field_t *field = 0;
+ int rc = 0;
+
+ field = qd_compose(QD_PERFORMATIVE_FOOTER, field);
+
+ // Stick the buffers into the footer compose field.
+ qd_compose_insert_binary_buffers(field, footer_props);
+
+ // This is the footer, we don't care about q2 and will disable it.
+ qd_message_Q2_holdoff_disable(message);
+
+ rc = qd_message_extend(message, field, 0);
+
+ qd_compose_free(field);
+ return rc;
+
+}
+
int qd_message_stream_data_append(qd_message_t *message, qd_buffer_list_t
*data, bool *q2_blocked)
{
unsigned int length = DEQ_SIZE(*data);
+
qd_composed_field_t *field = 0;
int rc = 0;
if (q2_blocked)
*q2_blocked = false;
- if (length == 0)
Review comment:
You're correct - the message has to have *something* in the body, so
yeah if we're trying to send bodyless meta-data this looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
