[
https://issues.apache.org/jira/browse/QUARKS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15205327#comment-15205327
]
Victor Dogaru commented on QUARKS-15:
-------------------------------------
I am wondering whether anyone has followed the procedure described in the
"Merging a PR" section of https://mahout.apache.org/developers/github.html.
Rather than pulling the PR branch into a separate clone, the PR merge happens
in the commiter's Github copy, then the commiter pushes changes to the ASF Git
repo.
Also, they recommend that the PR commit history is squashed into a single
commit, which keeps one commit per merge in the ASF Git history. As a good
practice, contributors should create a new branch for each PR. Using squash
makes it difficult to merge repeated PRs from the same branch.
> Document commit process
> -----------------------
>
> Key: QUARKS-15
> URL: https://issues.apache.org/jira/browse/QUARKS-15
> Project: Quarks
> Issue Type: Improvement
> Components: Documentation
> Reporter: Susan L. Cline
> Assignee: Susan L. Cline
> Priority: Minor
> Labels: commit, documentation,
> Attachments: after_merging_pull_request.jpg, committing_files.txt,
> github_user_fork.jpg, make_pull_request.jpg
>
>
> Attached is a text file of an example I went through to commit and pull files
> as a committer on quarks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
