Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/27#discussion_r66725743
--- Diff: parser/CMakeLists.txt ---
@@ -374,12 +374,15 @@ set_property(SOURCE
${CMAKE_CURRENT_BINARY_DIR}/SqlParser_gen.cpp APPEND PROPERT
include(CheckCXXCompilerFlag)
CHECK_CXX_COMPILER_FLAG("-Wno-deprecated-register"
COMPILER_HAS_WNO_DEPRECATED_REGISTER)
if (COMPILER_HAS_WNO_DEPRECATED_REGISTER)
- set_target_properties(quickstep_parser_SqlLexer PROPERTIES COMPILE_FLAGS
"-Wno-deprecated-register")
+ set_property(TARGET quickstep_parser_SqlLexer APPEND_STRING PROPERTY
COMPILE_FLAGS " -Wno-deprecated-register")
endif()
# GCC will make a warning for unsigned-signed comparisons which are
inherent
# in the lexer. For this, we turn off the sign compare.
-set_target_properties(quickstep_parser_SqlLexer PROPERTIES COMPILE_FLAGS
"-Wno-sign-compare")
+CHECK_CXX_COMPILER_FLAG("-Wno-sign-compare" COMPILER_HAS_WNO_SIGN_COMPARE)
+if (COMPILER_HAS_WNO_SIGN_COMPARE)
+ set_property(TARGET quickstep_parser_SqlLexer APPEND_STRING PROPERTY
COMPILE_FLAGS " -Wno-sign-compare")
+endif()
--- End diff --
@craig-chasseur I think changes in this file are not related to this PR.
What do you think of doing so in another separate PR? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
