Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/27#discussion_r66725967
--- Diff: storage/BasicColumnStoreTupleStorageSubBlock.cpp ---
@@ -671,6 +688,8 @@ void
BasicColumnStoreTupleStorageSubBlock::shiftNullBitmaps(
// total size of tuples contained in this sub-block. It could be done with
// less memory, although the implementation would be more complex.
bool BasicColumnStoreTupleStorageSubBlock::rebuildInternal() {
+ DEBUG_ASSERT(sort_specified_);
--- End diff --
Please use `DCHECK` from `glog`. `DEBUG_ASSERT` has been depreciated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
