Thanks Roman! To not disturb the ongoing work in existing PRs, I can take care of fixing the copyright in all existing files once we have closed the existing PRs (upto PR #28) . I’ll write a sed script to make the switch. Tentatively, lets plan on running this script this on Thursday 6/16 at noon CT. Soon after that, hopefully it will be merged into the master.
/** * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you may not use this file except in compliance * with the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, * software distributed under the License is distributed on an * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY * KIND, either express or implied. See the License for the * specific language governing permissions and limitations * under the License. **/ I’ll replace the existing NOTICE file in the root Quickstep directory that has the following contents tomorrow at June 14 at noon CT, so new files going in after that with the header above point to the right NOTICE file. For PRs being merged after the new NOTICE file is in the master, if you feel like you need to change the copyright notice (you don’t have to as I can take care of that when I run the sed script), please use the contents in the the copyright block above. Apache Quickstep (incubating) Copyright 2016 The Apache Software Foundation. This product includes software developed at The Apache Software Foundation (http://www.apache.org/). Portions Copyright (c) 2011-2015, Quickstep Technologies, LLC. Portions Copyright (c) 2015-2016, Pivotal Software, Inc. Portions Copyright (c) 2015-2016, Quickstep Research Group, University of Wisconsin-Madison. Please note it is my understanding that we don’t need to add our individual names or organization names to the NOTICE file, so don’t need to grow the list in the NOTICE file. Please let me know if you spot some errors in this approach. Cheers, Jignesh > On Jun 12, 2016, at 5:38 PM, Roman Shaposhnik <[email protected]> wrote: > > All of your copyright headers need to look exactly like this: > http://www.apache.org/legal/src-headers.html#headers > > In fact, this will be one of the requirements on which your first > ASF release will be predicated. All the other Copyright statements > need to be coalesced and moved into the NOTICE file similar to: > https://github.com/apache/incubator-hawq/blob/master/NOTICE > > Thanks, > Roman. > > On Mon, Jun 13, 2016 at 12:25 AM, Jignesh M. Patel <[email protected]> wrote: >> Others can correct me if I have this wrong, but we should it add any >> additional copyright anymore. It's implicit that contributions are to Apache. >> >> This also means less work for committers and we can avoid requests during PR >> to update the copyright. >> >> I suggest dropping the copyright line in this PR. >> >> Thanks! >> >> Sent from my iPhone >> >>> On Jun 12, 2016, at 2:37 PM, Zuyu Zhang <[email protected]> wrote: >>> >>> Hi, >>> >>> I was wondering how to update copyright info in a file header to reflect >>> outside contributors' change. >>> >>> More specifically, is it appropriate to add "Copyright 2016 The Apache >>> Quickstep Contributors."? >>> >>> https://github.com/apache/incubator-quickstep/pull/27/files#diff-357f532831c389c757e7c87c7db1c4d3R4 >>> >>> Cheers, >>> Zuyu
