Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/90#discussion_r74788824
--- Diff: expressions/aggregation/AggregationHandleAvg.hpp ---
@@ -127,6 +170,9 @@ class AggregationHandleAvg : public
AggregationConcreteHandle {
void mergeStates(const AggregationState &source,
AggregationState *destination) const override;
+ void mergeStatesFast(const uint8_t *source,
--- End diff --
Can you please align the parameters? I use a vim plugin called clang-format
which helps greatly in fixing all the style issues with minimal efforts. If you
need help in configuring that plugin, please let me know. It's a big time
saver.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
