Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/90#discussion_r74795095
--- Diff: expressions/aggregation/AggregationHandleAvg.hpp ---
@@ -156,11 +217,12 @@ class AggregationHandleAvg : public
AggregationConcreteHandle {
*/
void aggregateOnDistinctifyHashTableForGroupBy(
const AggregationStateHashTableBase &distinctify_hash_table,
- AggregationStateHashTableBase *aggregation_hash_table) const
override;
+ AggregationStateHashTableBase *aggregation_hash_table,
+ int index) const override;
- void mergeGroupByHashTables(
- const AggregationStateHashTableBase &source_hash_table,
- AggregationStateHashTableBase *destination_hash_table) const
override;
+ size_t getPayloadSize() const override {
--- End diff --
It is considered a good practice to use the ``std`` prefix in the header
file. Therefore, can you please change the ``size_t`` to ``std::size_t``?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
