Github user cramja commented on a diff in the pull request:
    --- Diff: cli/LineReaderBuffered.hpp ---
    @@ -0,0 +1,70 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + **/
    +#include "cli/LineReader.hpp"
    +namespace quickstep {
    +class LineReaderBuffered : public LineReader {
    + public:
    +  /**
    +   * A line reader which accepts a string buffer.
    +   * This does no IO and ignores any prompts given to the constructor.
    +   * @param default_prompt Ignored.
    +   * @param continue_prompt Ignored.
    --- End diff --
    how about:
       * @brief A line reader which accepts a string buffer.
       * Other line readers are ment to support some form of user interaction. 
This linereader does not and is intended for
       * programmer use- it does not print anything to stdout. Therefore it 
ignores any prompt strings given to the
       * inherited constructor.
       * @param default_prompt Not used by this line reader, but required by 
       * @param continue_prompt Not used by this line reader, but required by 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to