Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/237#discussion_r112826903
  
    --- Diff: expressions/scalar/Scalar.hpp ---
    @@ -55,6 +59,7 @@ class Scalar {
         kUnaryExpression,
         kBinaryExpression,
         kCaseExpression,
    +    kSharedExpression,
    --- End diff --
    
    This is a bug: the value of `kSharedExpression` should be same with its 
index in `kScalarDataSourceNames` defined in the source file.
    
    Suggest to reorder two values `SimpleCase` and `SharedExpression` in the 
source file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to