Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/237#discussion_r112845784
  
    --- Diff: query_optimizer/expressions/AttributeReference.cpp ---
    @@ -57,6 +60,22 @@ ::quickstep::Scalar *AttributeReference::concretize(
       return new ::quickstep::ScalarAttribute(*found_it->second);
     }
     
    +std::size_t AttributeReference::computeHash() const {
    +  return std::hash<std::size_t>()(static_cast<std::size_t>(id()));
    --- End diff --
    
    FYI, the hash implementation for an integer is to return itself. So, we 
could just return `id()`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to