Github user cramja commented on a diff in the pull request:
    --- Diff: query_optimizer/rules/ReuseAggregateExpressions.cpp ---
    @@ -194,7 +194,7 @@ P::PhysicalPtr ReuseAggregateExpressions::applyToNode(
                 sum_it == ref_map.end() ? kInvalidRef : sum_it->second.front();
             for (const std::size_t idx : avg_it->second) {
    -          agg_refs[idx].reset(new AggregateReference(sum_ref, count_ref));
    +          agg_refs[idx] = std::make_unique<AggregateReference>(sum_ref, 
    --- End diff --
    What is the difference between using the assignment and `make_unique` 
versus `reset` and `new`?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to