Github user jianqiao commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/240#discussion_r113066280
  
    --- Diff: query_optimizer/rules/ExtractCommonSubexpression.hpp ---
    @@ -111,7 +111,7 @@ class ExtractCommonSubexpression : public 
Rule<physical::Physical> {
       bool visitAndCount(
           const expressions::ExpressionPtr &expression,
           ScalarCounter *counter,
    -      ScalarHashable *hashable);
    +      ScalarHashable *hashable) const;
    --- End diff --
    
    These three methods involve the invoking of 
`optimizer_context_->nextExprId()` which modifies  the context (symbol id 
counter) of `optimizer_context_`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to