Github user jianqiao commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/257#discussion_r122325834
  
    --- Diff: query_optimizer/PhysicalGenerator.cpp ---
    @@ -176,6 +177,8 @@ P::PhysicalPtr PhysicalGenerator::optimizePlan() {
         rules.emplace_back(new AttachLIPFilters());
       }
     
    +  rules.push_back(std::make_unique<Partition>(optimizer_context_));
    --- End diff --
    
    Is it okay to move this rule before the two LIP-related rules? Currently 
the LIP information may be invalidated (and lead to incorrect results) if tree 
transformation happens after the two LIP passes.
    
    Meanwhile, better add some comments describing what additional information 
would be added into the physical nodes after this pass.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to