Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/257#discussion_r122334121
  
    --- Diff: query_optimizer/PhysicalGenerator.cpp ---
    @@ -176,6 +177,8 @@ P::PhysicalPtr PhysicalGenerator::optimizePlan() {
         rules.emplace_back(new AttachLIPFilters());
       }
     
    +  rules.push_back(std::make_unique<Partition>(optimizer_context_));
    --- End diff --
    
    In the single-node version on a `NUMA` machine, we needs this partition 
rule. Sure, I am adding a flag to switch this rule.
    
    Regarding the first question, if I put the partition rule before `LIP` 
rules, how could I process `FilterJoin` with partitioned inputs?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to