-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55709/
-----------------------------------------------------------
Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, Ramesh Mani,
Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1293
https://issues.apache.org/jira/browse/RANGER-1293
Repository: ranger
Description
-------
There were logic errors in create_rangerdb_user and grant_xa_db_user function.
The reason for the error is that the hosts_arr variable was set ["%",
"localhost"] as default value at the beginning. The hosts_arr variable will
include two localhost values if self.host equal to localhost. As a result, the
back code block will be executed repeatedly, the performance of the program
will be reduced. The error code is following:
hosts_arr =["%", "localhost"]
hosts_arr.append(self.host)
for host in hosts_arr:
business logic code block
>From the above code logic we can be seen that the business logic code block
>will be repeated twice when the db_host attribute is set to localhost in
>install.properties.
Diffs
-----
security-admin/scripts/dba_script.py e5a1f59
Diff: https://reviews.apache.org/r/55709/diff/
Testing
-------
Thanks,
Qiang Zhang
