----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55166/#review162263 -----------------------------------------------------------
Looks good, but I would make one change: > each_line = each_line.strip() It's probably better to create a new variable here, instead of assigning the value to the variable defined in the for loop. - Colm O hEigeartaigh On Jan. 19, 2017, 6:37 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55166/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2017, 6:37 a.m.) > > > Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, Ramesh Mani, > Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1290 > https://issues.apache.org/jira/browse/RANGER-1290 > > > Repository: ranger > > > Description > ------- > > There was a logical error in parsing the configuration file when executing > the database script. > Command line starting with ’#‘ have not been filtered out during parsing the > configuration file to get configurating value. If we use '#' to comment a > line and it includes '=', the comment will not work. On the left of the '=', > it will be parsed as a key and the right will be parsed as a value. As a > result, there are as follows problems: > 1. There are invalid attribute values. > 2. Invalid parsing will degrade the performance of program. > > > Diffs > ----- > > security-admin/scripts/dba_script.py e5a1f59 > > Diff: https://reviews.apache.org/r/55166/diff/ > > > Testing > ------- > > > Thanks, > > Qiang Zhang > >
