----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56192/#review163911 -----------------------------------------------------------
agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java (line 508) <https://reviews.apache.org/r/56192/#comment235427> Consider printing the action taken to the error log, such as "Ignoring, and continuing with the old TGT.." agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java (line 642) <https://reviews.apache.org/r/56192/#comment235423> Consider printing jaasConfigAppName to debug log here. agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java (line 645) <https://reviews.apache.org/r/56192/#comment235428> Can the entries be null if incorrect jaasConfigAppName is given? If so, a null-check may be required here. agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java (line 657) <https://reviews.apache.org/r/56192/#comment235424> Consider checking if both principal and keytab are non-null before trying to log in. agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java (line 659) <https://reviews.apache.org/r/56192/#comment235425> Consider printing principal here. agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java (line 665) <https://reviews.apache.org/r/56192/#comment235426> Consider printing jaasConfigAppName, principal here. - Abhay Kulkarni On Feb. 1, 2017, 10:35 p.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56192/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2017, 10:35 p.m.) > > > Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan > Periasamy. > > > Bugs: RANGER-1338 > https://issues.apache.org/jira/browse/RANGER-1338 > > > Repository: ranger > > > Description > ------- > > RANGER-1338:Ranger Plugin failed to download policy when JaasConfig alone is > used to set the UGI instead of Principal/Keytab > > > Diffs > ----- > > agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java > d440b85 > > knox-agent/src/main/java/org/apache/ranger/authorization/knox/RangerPDPKnoxFilter.java > 2ec5300 > > storm-agent/src/main/java/org/apache/ranger/authorization/storm/authorizer/RangerStormAuthorizer.java > c66b665 > > Diff: https://reviews.apache.org/r/56192/diff/ > > > Testing > ------- > > > Thanks, > > Ramesh Mani > >
