----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56192/#review163929 -----------------------------------------------------------
Fix it, then Ship it! agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java (line 664) <https://reviews.apache.org/r/56192/#comment235449> Consider adding else clause which prints specific error message (about principal/keytab being null) and throws exception. Then caller will not need to check return value of MiscUtil.getUGILoginUser() - Abhay Kulkarni On Feb. 2, 2017, 1:27 a.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56192/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2017, 1:27 a.m.) > > > Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan > Periasamy. > > > Bugs: RANGER-1338 > https://issues.apache.org/jira/browse/RANGER-1338 > > > Repository: ranger > > > Description > ------- > > RANGER-1338:Ranger Plugin failed to download policy when JaasConfig alone is > used to set the UGI instead of Principal/Keytab > > > Diffs > ----- > > agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java > d440b85 > > knox-agent/src/main/java/org/apache/ranger/authorization/knox/RangerPDPKnoxFilter.java > 2ec5300 > > storm-agent/src/main/java/org/apache/ranger/authorization/storm/authorizer/RangerStormAuthorizer.java > c66b665 > > Diff: https://reviews.apache.org/r/56192/diff/ > > > Testing > ------- > > Testing done in Local VM > > > Thanks, > > Ramesh Mani > >
