Hi,
After reviewing the code base, I have a couple of issues, which I would
like to ask:
* There are lot's of places, where the fields could be marked as private
and/or final, but it's omitted, why ? Is it a lack of time, or interest ?
Or the project prefer this style?
* Why the xml configuration files are used for spring? Using java is much
more safe
* There are lot of static variable used, instead of relying on Spring (or
even Guice) to inject the necessary dependencies. Or there is a
RangerDaoManagerBase, which is just for looking up DAO classes. Why ? Is it
because the springframework is too old for proper generic service injection
support? Why it can't be upgraded from 3.1.3 to a current - 4.3.x ?
* Lot's of places, where there are empty blocks, even empty methods - or
exception "handling" as 'e.printStackTrace()'
* And smaller issues, like initializing fields unnecessarily, or calling
x.equalsIgnoreCase("something") instead of "something".equalsIgnoreCase(x)
What do you think, is it worth working on these?
Best regards,
Zsombor
