Zsombor Thanks for going through the code. I don’t think we have any strong reasons for doing things one way or another. It is generally we are so caught up with our day to day to work, that you don't want to change anything that is working and risk breaking something else.
We have constantly refactoring code to improve the performance or add features. Generally, it is a good idea to review newer commits for these issues. We can maintain a to-do or not-to-do list as a guideline for reviewers. For existing issues, it would good to create JIRAs to track them. If the issues are trivial, then it would be a good place for new members to contribute. Thanks Bosco On 2/3/17, 7:41 AM, "Velmurugan Periasamy" <[email protected] on behalf of [email protected]> wrote: +1 My suggestion is to open separate JIRAs for addressing each of these items. Although they don¹t affect functionality these can be worked on as coding best practices. From: Colm O hEigeartaigh <[email protected]> Reply-To: "[email protected]" <[email protected]>, "[email protected]" <[email protected]> Date: Friday, February 3, 2017 at 6:37 AM To: "[email protected]" <[email protected]>, "[email protected]" <[email protected]> Subject: Re: Code-style Hi, Contributions to the project, even minor ones, are always welcome. I've cherry-picked some of your comments below that you could work on patches for, some of the other suggestions are a bit more contraversial and could be considered later. On Fri, Feb 3, 2017 at 12:37 AM, Zsombor <[email protected]> wrote: > > * There are lot's of places, where the fields could be marked as private > and/or final, but it's omitted, why ? Is it a lack of time, or interest ? > No reason, please feel free to submit a patch. * Lot's of places, where there are empty blocks, even empty methods - or > exception "handling" as 'e.printStackTrace()' > Yes agreed this needs to be improved. > * And smaller issues, like initializing fields unnecessarily, or calling > x.equalsIgnoreCase("something") instead of "something".equalsIgnoreCase(x) > > Again, please submit a patch for this. Colm. > What do you think, is it worth working on these? > > Best regards, > Zsombor > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com
