----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56431/#review164656 -----------------------------------------------------------
We should go further, and check to see if the JAVA_HOME variable is a directory, rather than just checking to see if it's empty (in both scripts) - Colm O hEigeartaigh On Feb. 8, 2017, 7:01 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56431/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2017, 7:01 a.m.) > > > Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, Ramesh Mani, > Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1362 > https://issues.apache.org/jira/browse/RANGER-1362 > > > Repository: ranger > > > Description > ------- > > The installer of the usersync and unixauthservice can be executed when > JAVA_HOME environment variable was set empty. The result is that there are > many errors when installing UserSync and unixauthservice. > > The tagsync installer checked JAVA_HOME environment variable. It would print > error information and abort if JAVA_HOME environment variable is empty during > installing tagsync. We should handle the exception for the installer of the > usersync and unixauthservice as well as tagsync. > > > The installer of the usersync and unixauthservice is the same program. They > will be modified at the same time after we modifed the setup.sh of the > unixauthservice project. > > > Diffs > ----- > > unixauthservice/scripts/setup.sh cf785a1 > > Diff: https://reviews.apache.org/r/56431/diff/ > > > Testing > ------- > > > Thanks, > > Qiang Zhang > >
