> On 二月 8, 2017, 9:53 a.m., Colm O hEigeartaigh wrote: > > We should go further, and check to see if the JAVA_HOME variable is a > > directory, rather than just checking to see if it's empty (in both scripts) > > Qiang Zhang wrote: > Ok. I agree with your proposal. I rebuild the patch. > > Qiang Zhang wrote: > I had rebuilt and updated the patch. Thanks! > > Colm O hEigeartaigh wrote: > The patch only contains the fix for the unixauthservice and not the > tagsyncservice?
As described in the description the installer of the usersync and unixauthservice is the same program. In the process of packing, it is compiled into different packages. So they will be modified at the same time after we modifed the setup.sh of the unixauthservice project. - Qiang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56431/#review164656 ----------------------------------------------------------- On 二月 8, 2017, 2:57 p.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56431/ > ----------------------------------------------------------- > > (Updated 二月 8, 2017, 2:57 p.m.) > > > Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, Ramesh Mani, > Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1362 > https://issues.apache.org/jira/browse/RANGER-1362 > > > Repository: ranger > > > Description > ------- > > The installer of the usersync and unixauthservice can be executed when > JAVA_HOME environment variable was set empty. The result is that there are > many errors when installing UserSync and unixauthservice. > > The tagsync installer checked JAVA_HOME environment variable. It would print > error information and abort if JAVA_HOME environment variable is empty during > installing tagsync. We should handle the exception for the installer of the > usersync and unixauthservice as well as tagsync. > > > The installer of the usersync and unixauthservice is the same program. They > will be modified at the same time after we modifed the setup.sh of the > unixauthservice project. > > > Diffs > ----- > > unixauthservice/scripts/setup.sh cf785a1 > > Diff: https://reviews.apache.org/r/56431/diff/ > > > Testing > ------- > > > Thanks, > > Qiang Zhang > >
