----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55669/ -----------------------------------------------------------
(Updated Feb. 13, 2017, 1:07 p.m.) Review request for ranger. Changes ------- I updated the patch again to get it to apply to master...please take a look so that I can apply it. Bugs: RANGER-1318 https://issues.apache.org/jira/browse/RANGER-1318 Repository: ranger Description ------- Currently, duplicate code appears in several places to parse XML. Instead it should all be consolidated in a single place. Diffs (updated) ----- agents-common/src/main/java/org/apache/ranger/plugin/util/XMLUtils.java PRE-CREATION embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java 9668e47 security-admin/src/main/java/org/apache/ranger/common/RangerProperties.java cb8b825 security-admin/src/main/java/org/apache/ranger/common/XMLPropertiesUtil.java 29fc78a ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java a4b12b2 unixauthclient/src/main/java/org/apache/ranger/authentication/unix/jaas/RemoteUnixLoginModule.java 178eb53 unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java 175307f Diff: https://reviews.apache.org/r/55669/diff/ Testing ------- Thanks, Colm O hEigeartaigh