-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55669/#review168243
-----------------------------------------------------------
Hi Colm,
There are following warnings when I apply the patch.
Applying: RANGER-1318 - Consolidate XML configuration parsing
.git/rebase-apply/patch:55: trailing whitespace.
.git/rebase-apply/patch:57: trailing whitespace.
.git/rebase-apply/patch:69: trailing whitespace.
.git/rebase-apply/patch:75: trailing whitespace.
.git/rebase-apply/patch:100: trailing whitespace.
warning: squelched 4 whitespace errors
warning: 9 lines add whitespace errors.
Could you eliminate these warnings before ship it?
- Qiang Zhang
On March 7, 2017, 5:49 p.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55669/
> -----------------------------------------------------------
>
> (Updated March 7, 2017, 5:49 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1318
> https://issues.apache.org/jira/browse/RANGER-1318
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently, duplicate code appears in several places to parse XML. Instead it
> should all be consolidated in a single place.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/XMLUtils.java
> PRE-CREATION
>
> embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java
> 635e63f
> security-admin/src/main/java/org/apache/ranger/common/RangerProperties.java
> cb8b825
>
> security-admin/src/main/java/org/apache/ranger/common/XMLPropertiesUtil.java
> 29fc78a
>
> ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java
> d839b39
>
> unixauthclient/src/main/java/org/apache/ranger/authentication/unix/jaas/RemoteUnixLoginModule.java
> 178eb53
>
> unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java
> 11e0c92
>
>
> Diff: https://reviews.apache.org/r/55669/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>
