----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56580/#review165682 -----------------------------------------------------------
The changes are so large here I think we should wait until we get 0.7 out before applying this to master. - Colm O hEigeartaigh On Feb. 13, 2017, 3:44 p.m., Zsombor Gegesy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56580/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2017, 3:44 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1377 > https://issues.apache.org/jira/browse/RANGER-1377 > > > Repository: ranger > > > Description > ------- > > * use collection methods properly - addAll/removeAll/isEmpty > * string comparison methods > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java d4ab8d7 > security-admin/src/main/java/org/apache/ranger/biz/KmsKeyMgr.java e90b106 > security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java > 5521ae8 > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 15f205a > security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java f512049 > security-admin/src/main/java/org/apache/ranger/biz/SessionMgr.java ec744ea > security-admin/src/main/java/org/apache/ranger/biz/XAuditMgr.java 3542da2 > security-admin/src/main/java/org/apache/ranger/common/AppConstants.java > 7fa2292 > security-admin/src/main/java/org/apache/ranger/common/DateUtil.java 7babd80 > security-admin/src/main/java/org/apache/ranger/common/MapUtil.java 93fc76b > security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java > 830a049 > security-admin/src/main/java/org/apache/ranger/common/RESTErrorUtil.java > 967804a > security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java > 4fb52a4 > security-admin/src/main/java/org/apache/ranger/common/SearchGroup.java > 77119b1 > security-admin/src/main/java/org/apache/ranger/common/SearchUtil.java > f4fcfb2 > security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java > 6864c5a > security-admin/src/main/java/org/apache/ranger/common/StringUtil.java > b6192ae > security-admin/src/main/java/org/apache/ranger/db/RangerDaoManager.java > e3b878b > security-admin/src/main/java/org/apache/ranger/db/RangerDaoManagerBase.java > d718441 > security-admin/src/main/java/org/apache/ranger/db/XXResourceDao.java > 9fa77f2 > > security-admin/src/main/java/org/apache/ranger/entity/XXAccessAuditBase.java > 8efcfc3 > security-admin/src/main/java/org/apache/ranger/entity/XXAsset.java 158c966 > security-admin/src/main/java/org/apache/ranger/entity/XXAuditMap.java > 95c2bf6 > security-admin/src/main/java/org/apache/ranger/entity/XXAuthSession.java > deedc87 > security-admin/src/main/java/org/apache/ranger/entity/XXGroup.java 04aedbd > security-admin/src/main/java/org/apache/ranger/entity/XXPermMap.java > 7c6b96c > security-admin/src/main/java/org/apache/ranger/entity/XXPortalUser.java > f7df09e > security-admin/src/main/java/org/apache/ranger/entity/XXPortalUserRole.java > 97f52c4 > security-admin/src/main/java/org/apache/ranger/entity/XXResource.java > e571a4f > > security-admin/src/main/java/org/apache/ranger/entity/XXServiceResource.java > 961627a > > security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElement.java > 16dca97 > > security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElementValue.java > 82ce8a0 > security-admin/src/main/java/org/apache/ranger/entity/XXTag.java 9155385 > security-admin/src/main/java/org/apache/ranger/entity/XXTagAttribute.java > 1c88288 > > security-admin/src/main/java/org/apache/ranger/entity/XXTagAttributeDef.java > 5c6ff58 > security-admin/src/main/java/org/apache/ranger/entity/XXTagDef.java 818908b > security-admin/src/main/java/org/apache/ranger/entity/XXTagResourceMap.java > 4b8b3ec > security-admin/src/main/java/org/apache/ranger/entity/XXTrxLog.java ceea47b > security-admin/src/main/java/org/apache/ranger/entity/XXUser.java 512c567 > > security-admin/src/main/java/org/apache/ranger/patch/PatchMigration_J10002.java > d77e4f9 > > security-admin/src/main/java/org/apache/ranger/patch/PatchPersmissionModel_J10003.java > a48f486 > > security-admin/src/main/java/org/apache/ranger/patch/PatchTagModulePermission_J10005.java > 6f9350d > > security-admin/src/main/java/org/apache/ranger/patch/cliutil/DbToSolrMigrationUtil.java > 1ddd367 > > security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java > fb438a7 > security-admin/src/main/java/org/apache/ranger/rest/PublicAPIs.java d3c22d7 > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > daf3c8e > security-admin/src/main/java/org/apache/ranger/rest/ServiceRESTUtil.java > e84a1aa > > security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java > 3fdd5c2 > > security-admin/src/main/java/org/apache/ranger/security/listener/RangerHttpSessionListener.java > e0069b6 > > security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java > 8d9363a > > security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthSuccessHandler.java > 948d328 > > security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthenticationEntryPoint.java > e7e5f5d > > security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerCSRFPreventionFilter.java > 36a0fa3 > > security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKRBAuthenticationFilter.java > c8d22aa > > security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKrbFilter.java > d10fc46 > > security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java > 7d8fdb2 > > security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerUsernamePasswordAuthenticationFilter.java > 62e23c0 > > security-admin/src/main/java/org/apache/ranger/service/AbstractBaseResourceService.java > 9a4aa3b > > security-admin/src/main/java/org/apache/ranger/service/RangerBaseModelService.java > 482f10c > > security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java > 8d9776a > > security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefServiceBase.java > aacf398 > > security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java > 004524b > > security-admin/src/main/java/org/apache/ranger/service/RangerServiceServiceBase.java > 75237de > security-admin/src/main/java/org/apache/ranger/service/UserService.java > 164e241 > security-admin/src/main/java/org/apache/ranger/service/XAssetService.java > 81c720d > > security-admin/src/main/java/org/apache/ranger/service/XAuditMapService.java > 1dfe19f > security-admin/src/main/java/org/apache/ranger/service/XGroupService.java > c478dbc > > security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java > 0d735da > security-admin/src/main/java/org/apache/ranger/service/XPermMapService.java > bc335cc > security-admin/src/main/java/org/apache/ranger/service/XPolicyService.java > f3f7c80 > > security-admin/src/main/java/org/apache/ranger/service/XPortalUserService.java > bb12e3e > > security-admin/src/main/java/org/apache/ranger/service/XResourceService.java > 817fdda > security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java > 1c43445 > security-admin/src/main/java/org/apache/ranger/service/XUserService.java > 0f8156a > > security-admin/src/main/java/org/apache/ranger/service/filter/RangerRESTAPIFilter.java > 5b78925 > > security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java > 917c760 > security-admin/src/main/java/org/apache/ranger/solr/SolrMgr.java 3f7935e > security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java e0ab372 > security-admin/src/main/java/org/apache/ranger/util/RangerEnumUtil.java > 6084972 > security-admin/src/main/java/org/apache/ranger/util/RangerRestUtil.java > 9a2a505 > security-admin/src/main/java/org/apache/ranger/util/RestUtil.java b50d161 > security-admin/src/main/java/org/apache/ranger/view/VXKmsKey.java d7a0b4d > > security-admin/src/main/java/org/apache/ranger/view/VXMetricPolicyCount.java > bb18775 > security-admin/src/test/java/org/apache/ranger/audit/TestAuditQueue.java > dee3156 > security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java > 2b773da > > Diff: https://reviews.apache.org/r/56580/diff/ > > > Testing > ------- > > > Thanks, > > Zsombor Gegesy > >
