----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56571/#review165855 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java (line 1448) <https://reviews.apache.org/r/56571/#comment237683> instantiation of 'defaultRangerPolicies' (line #1448) can go inside the 'if' block at line #1453. security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java (line 3805) <https://reviews.apache.org/r/56571/#comment237703> Is this method supposed to add certain configured users/groups to all policy items in default policies? The implementation seems to do a lot more; please review and simplify. - Madhan Neethiraj On Feb. 11, 2017, 7:37 a.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56571/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2017, 7:37 a.m.) > > > Review request for ranger, Madhan Neethiraj, Selvamohan Neethiraj, and > Velmurugan Periasamy. > > > Bugs: RANGER-1321 > https://issues.apache.org/jira/browse/RANGER-1321 > > > Repository: ranger > > > Description > ------- > > RANGER-1321:Provide a mechanism to create service-specific default policies > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java > 73027a0 > security-admin/pom.xml 0fcfc5a > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > cb67b6a > security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java > 2b773da > > Diff: https://reviews.apache.org/r/56571/diff/ > > > Testing > ------- > > Test in Local VM > > > Thanks, > > Ramesh Mani > >
