----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56571/#review166305 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java (line 124) <https://reviews.apache.org/r/56571/#comment238239> Consider marking this method as private, as we don't expect the implementations to override or call this one. Review other helper methods as well. agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java (line 142) <https://reviews.apache.org/r/56571/#comment238241> Consider moving line #142 inside createDefaultPolicyItem() method - as the method has access to 'service' config, from which the userList is derived. - Madhan Neethiraj On Feb. 18, 2017, 2:06 a.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56571/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2017, 2:06 a.m.) > > > Review request for ranger, Madhan Neethiraj, Selvamohan Neethiraj, and > Velmurugan Periasamy. > > > Bugs: RANGER-1321 > https://issues.apache.org/jira/browse/RANGER-1321 > > > Repository: ranger > > > Description > ------- > > RANGER-1321:Provide a mechanism to create service-specific default policies > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java > 73027a0 > > agents-common/src/main/java/org/apache/ranger/services/tag/RangerServiceTag.java > 3940154 > > plugin-kms/src/main/java/org/apache/ranger/services/kms/RangerServiceKMS.java > 8b41ae3 > security-admin/pom.xml 0fcfc5a > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > cb67b6a > security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java > 2b773da > > Diff: https://reviews.apache.org/r/56571/diff/ > > > Testing > ------- > > Test in Local VM > > > Thanks, > > Ramesh Mani > >
