----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57371/#review168121 -----------------------------------------------------------
Ship it! Ship It! - Qiang Zhang On 三月 7, 2017, 11:55 a.m., Colm O hEigeartaigh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57371/ > ----------------------------------------------------------- > > (Updated 三月 7, 2017, 11:55 a.m.) > > > Review request for ranger. > > > Bugs: RANGER-1426 > https://issues.apache.org/jira/browse/RANGER-1426 > > > Repository: ranger > > > Description > ------- > > RangerBaseService.validateConfig currently returns a HashMap. It should > return a Map instead, as we should program to interfaces in Java. > > > Diffs > ----- > > agents-common/src/main/java/org/apache/ranger/plugin/client/BaseClient.java > 2a570cb > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java > 73027a0 > > agents-common/src/main/java/org/apache/ranger/services/tag/RangerServiceTag.java > 98413d9 > > hbase-agent/src/main/java/org/apache/ranger/services/hbase/RangerServiceHBase.java > 7d5bf9b > > hbase-agent/src/main/java/org/apache/ranger/services/hbase/client/HBaseClient.java > f0f086c > > hbase-agent/src/main/java/org/apache/ranger/services/hbase/client/HBaseResourceMgr.java > c033b00 > > hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/RangerServiceHdfs.java > e1648dc > > hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsClient.java > d712b08 > > hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsResourceMgr.java > bb6aa496 > > hive-agent/src/main/java/org/apache/ranger/services/hive/RangerServiceHive.java > 9ce0347 > > hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java > de36852 > > hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveResourceMgr.java > 0a15f70 > > knox-agent/src/main/java/org/apache/ranger/services/knox/RangerServiceKnox.java > 813b690 > > knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxClient.java > f657795 > > knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxResourceMgr.java > 1d086fb > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/RangerServiceAtlas.java > 7e7dfe3 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasResourceMgr.java > cb2ac9a > > plugin-kafka/src/main/java/org/apache/ranger/services/kafka/RangerServiceKafka.java > 2f031fa > > plugin-kafka/src/main/java/org/apache/ranger/services/kafka/client/ServiceKafkaClient.java > c908550 > > plugin-kafka/src/main/java/org/apache/ranger/services/kafka/client/ServiceKafkaConnectionMgr.java > 0056c84 > > plugin-kms/src/main/java/org/apache/ranger/services/kms/RangerServiceKMS.java > 8b41ae3 > > plugin-kms/src/main/java/org/apache/ranger/services/kms/client/KMSClient.java > 016065d > > plugin-kms/src/main/java/org/apache/ranger/services/kms/client/KMSResourceMgr.java > 09f2a6f > > plugin-solr/src/main/java/org/apache/ranger/services/solr/RangerServiceSolr.java > 8fa51ea > > plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrClient.java > 74da115 > > plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrConnectionMgr.java > 81b664c > > plugin-yarn/src/main/java/org/apache/ranger/services/yarn/RangerServiceYarn.java > 7b11ded > > plugin-yarn/src/main/java/org/apache/ranger/services/yarn/client/YarnClient.java > 7dbfa6d > > plugin-yarn/src/main/java/org/apache/ranger/services/yarn/client/YarnResourceMgr.java > 35b138f > security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java f512049 > > storm-agent/src/main/java/org/apache/ranger/services/storm/RangerServiceStorm.java > dccd311 > > storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormClient.java > cb56609 > > storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormResourceMgr.java > 43960b3 > > > Diff: https://reviews.apache.org/r/57371/diff/1/ > > > Testing > ------- > > > Thanks, > > Colm O hEigeartaigh > >
