> On March 30, 2017, 8:40 p.m., Ramesh Mani wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java > > Lines 306 (patched) > > <https://reviews.apache.org/r/58067/diff/1/?file=1680711#file1680711line306> > > > > Do we need this to be set to null explicitly? Null can be its default > > value when "enableHiveMetastoreLookup" is false.
This is needed as once if hiveSiteFilePath variable is set it presist even if the custom property (hive.site.file.path) is removed in the same context so to handle that scenario we need to set it to null. - Ankita ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58067/#review170639 ----------------------------------------------------------- On March 30, 2017, 3:32 a.m., Ankita Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58067/ > ----------------------------------------------------------- > > (Updated March 30, 2017, 3:32 a.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1483 > https://issues.apache.org/jira/browse/RANGER-1483 > > > Repository: ranger > > > Description > ------- > > Currently, ranger hive service definition uses hiveserver2(hs2) jdbc driver > to fetch hive db/table info, which is used to populate drop downs while > creating/updating policies. Adding ranger hive service definition to also use > hive metastore client which read from hive metastore db. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java > 00374de > > hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java > 734c8e7 > security-admin/pom.xml 77f2b25 > security-admin/src/main/webapp/scripts/views/service/ConfigurationList.js > dcc85ab > > > Diff: https://reviews.apache.org/r/58067/diff/2/ > > > Testing > ------- > > 1. Tested on Simple environment. > 2. Tested on Secure cluster > 3. Tested with SSL > > > Thanks, > > Ankita Sinha > >
