----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58067/#review170639 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java Lines 76 (patched) <https://reviews.apache.org/r/58067/#comment243517> Please move this along with other boolean variable declaration as coding practice. Do this for other class also where you declared similar boolean variables. agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java Lines 306 (patched) <https://reviews.apache.org/r/58067/#comment243515> Do we need this to be set to null explicitly? Null can be its default value when "enableHiveMetastoreLookup" is false. hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java Lines 602 (patched) <https://reviews.apache.org/r/58067/#comment243511> This Debug message can have the "file path"? please review other similar error message have "filepath" in this debug message. - Ramesh Mani On March 30, 2017, 3:32 a.m., Ankita Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58067/ > ----------------------------------------------------------- > > (Updated March 30, 2017, 3:32 a.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1483 > https://issues.apache.org/jira/browse/RANGER-1483 > > > Repository: ranger > > > Description > ------- > > Currently, ranger hive service definition uses hiveserver2(hs2) jdbc driver > to fetch hive db/table info, which is used to populate drop downs while > creating/updating policies. Adding ranger hive service definition to also use > hive metastore client which read from hive metastore db. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java > 00374de > > hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java > 734c8e7 > security-admin/pom.xml 77f2b25 > security-admin/src/main/webapp/scripts/views/service/ConfigurationList.js > dcc85ab > > > Diff: https://reviews.apache.org/r/58067/diff/1/ > > > Testing > ------- > > 1. Tested on Simple environment. > 2. Tested on Secure cluster > 3. Tested with SSL > > > Thanks, > > Ankita Sinha > >
