-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57987/
-----------------------------------------------------------
(Updated March 31, 2017, 12:50 p.m.)
Review request for ranger.
Changes
-------
With git format-patch
Bugs: RANGER-1478
https://issues.apache.org/jira/browse/RANGER-1478
Repository: ranger
Description
-------
RangerPolicyEngineOptions has a lot of public fields, which is written from
various places from the code base, which should be avoided. That object is
configured from RangerConfiguration, but in the middle of the plugin
initialization code, which makes this a bit more complex, than it should be.
Suggestions:
RangerConfiguration should be treated as an object, not a static facade for
a couple of config values
RangerPolicyEngineOptions should get his configuration from directly the
RangerConfiguration, in an explicit, encapsulated way.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineCache.java
5376b52
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineOptions.java
a9027bc
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
acf8d15
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 6176319
Diff: https://reviews.apache.org/r/57987/diff/2/
Changes: https://reviews.apache.org/r/57987/diff/1-2/
Testing
-------
Thanks,
Zsombor Gegesy
