-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57987/
-----------------------------------------------------------
(Updated April 21, 2017, 12:17 p.m.)
Review request for ranger.
Changes
-------
Remove the unused setter, and rename the getter to better reflect that it
returns the delegated ranger admin policy options.
Bugs: RANGER-1478
https://issues.apache.org/jira/browse/RANGER-1478
Repository: ranger
Description
-------
RangerPolicyEngineOptions has a lot of public fields, which is written from
various places from the code base, which should be avoided. That object is
configured from RangerConfiguration, but in the middle of the plugin
initialization code, which makes this a bit more complex, than it should be.
Suggestions:
RangerConfiguration should be treated as an object, not a static facade for
a couple of config values
RangerPolicyEngineOptions should get his configuration from directly the
RangerConfiguration, in an explicit, encapsulated way.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineCache.java
5376b52
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineOptions.java
a9027bc
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
7010b43
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java b9f1832
Diff: https://reviews.apache.org/r/57987/diff/3/
Changes: https://reviews.apache.org/r/57987/diff/2-3/
Testing
-------
Thanks,
Zsombor Gegesy
