-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58660/#review173061
-----------------------------------------------------------



1.      I would like the format to be like 
ranger-admin-${hostname}-${user}.log.  
a.       ranger-admin-…  will be consistent with /etc/ranger/admin and 
/var/log/ranger/admin we follow with Ambari
b.      Putting ${user} in the end will help ignore the least significant 
variable by using “*”. E.g. we can select by /var/log/ranger/ranger-admin-*.log 
or /var/log/ranger/ranger-admin-MYHOST-*.log
2.      We should assume that this will only affect manual install. With Ambari 
install, it generates it’s own log4j properties file.
3.      We have to explicitly document this change in the next release

- Don Bosco Durai


On April 24, 2017, 9:01 a.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58660/
> -----------------------------------------------------------
> 
> (Updated April 24, 2017, 9:01 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
> Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1540
>     https://issues.apache.org/jira/browse/RANGER-1540
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Log is very important for big data platform. The main purpose of log analysis 
> is that we need to know who is running the service, in which machine running 
> service, which service out of the problem. The ranger security admin should 
> support the feature.
> Implement logic:
> 1. Modify the value of log4j.appender.xa_log_appender.file from $
> {logdir}/ranger_admin.log to ${logdir}
> 
> /ranger-$
> {user}rangeradmin${hostname}.log in 
> /security-admin/src/main/webapp/WEB-INF/log4j.properties file.
> 2. Pass ${user}
> 
> and $
> {hostname}
> 
> as parameters to org.apache.ranger.server.tomcat.EmbeddedServer.
> 3. User obtains the user and hostname information by parsing the log file 
> name.
> 
> 
> Diffs
> -----
> 
>   embeddedwebserver/scripts/ranger-admin-services.sh f2d2bf5 
>   security-admin/src/main/webapp/WEB-INF/log4j.properties 211de86 
> 
> 
> Diff: https://reviews.apache.org/r/58660/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Reply via email to