> On May 10, 2017, 1:53 p.m., Colm O hEigeartaigh wrote:
> > Please make sure there are spaces before open curly brackets, e.g. "if
> > (aPassword.contains(",")){" and "}else{".
> >
> > The default values are defined both in
> > "security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java"
> > and
> > "agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java".
> > Why not just have them in agents-common and refer to them in the admin
> > module?
I have updated the patch as per your comments.
- bhavik
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59143/#review174471
-----------------------------------------------------------
On May 11, 2017, 10:25 a.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59143/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 10:25 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan
> Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj,
> and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1571
> https://issues.apache.org/jira/browse/RANGER-1571
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Code Improvement To Follow Best Practices.
>
>
> Diffs
> -----
>
>
> agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java
> 29983da
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java
> f32355a
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java
> 33e0e85
>
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java
> f194b18
> security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml
> 0feecfe
>
>
> Diff: https://reviews.apache.org/r/59143/diff/3/
>
>
> Testing
> -------
>
> 1. Tested Ranger Admin & Ranger KMS rest calls.
> 2. Verified Test-Connection for plugins on kerberized environment.
>
>
> Thanks,
>
> bhavik patel
>
>
