> On 五月 13, 2017, 1:46 p.m., Velmurugan Periasamy wrote: > > embeddedwebserver/scripts/ranger-admin-services.sh > > Lines 71 (patched) > > <https://reviews.apache.org/r/59255/diff/1/?file=1717758#file1717758line71> > > > > Users can set RANGER_PID_DIR_PATH if they don't want to use default > > path. So what is the need for an additional variable?
This function is perfect if user independently use our ranger. There is defect for ranger when they integrate Ranger into the big data platform or business systems to uniform install and run Ranger. These systems require services to support multiple instances, that is, the same service can been run multiple instances in the same node. These systems need to dynamically change the pid file path to avoid conflicts when they run service. They hope that ranger also has the ability to dynamically change the pid path at startup. We should meet this need by minor modifications without affecting the current function and logic. - pengjianhua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59255/#review174894 ----------------------------------------------------------- On 五月 13, 2017, 7:14 a.m., pengjianhua wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59255/ > ----------------------------------------------------------- > > (Updated 五月 13, 2017, 7:14 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1575 > https://issues.apache.org/jira/browse/RANGER-1575 > > > Repository: ranger > > > Description > ------- > > Some users hope that the pid file of the Ranger Admin can be unified > management when they integrate Ranger into the big data platform or business > systems to uniform install and run Ranger. > We should support the need in the case of compatibility with existing logic. > When running ranger, users can set the pid file to meet their own needs. > > We will explicitly document this change in the next release. > > > Diffs > ----- > > embeddedwebserver/scripts/ranger-admin-services.sh a81219b > > > Diff: https://reviews.apache.org/r/59255/diff/1/ > > > Testing > ------- > > > Thanks, > > pengjianhua > >
