----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60134/#review178097 -----------------------------------------------------------
Looks fine. You have "Unable find" twice in the code...should be "Unable to find" - Colm O hEigeartaigh On June 15, 2017, 10:23 p.m., Zsombor Gegesy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60134/ > ----------------------------------------------------------- > > (Updated June 15, 2017, 10:23 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1646 > https://issues.apache.org/jira/browse/RANGER-1646 > > > Repository: ranger > > > Description > ------- > > Instead of shallowing the exceptions - and returning nulls, which later > results in a 'SSLContext must not be null' error, it would be better, if the > process would fail early, and provide detailed error message in the > exceptions, so the user could solve it. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java > 784023b > > > Diff: https://reviews.apache.org/r/60134/diff/1/ > > > Testing > ------- > > > Thanks, > > Zsombor Gegesy > >