-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60134/#review178208
-----------------------------------------------------------



Another trivial change - there are several instances of "+" where it is not 
surrounded either side by a space, e.g. mKeyStoreFile+"

- Colm O hEigeartaigh


On June 16, 2017, 11:48 a.m., Zsombor Gegesy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60134/
> -----------------------------------------------------------
> 
> (Updated June 16, 2017, 11:48 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1646
>     https://issues.apache.org/jira/browse/RANGER-1646
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Instead of shallowing the exceptions - and returning nulls, which later 
> results in a 'SSLContext must not be null' error, it would be better, if the 
> process would fail early, and provide detailed error message in the 
> exceptions, so the user could solve it.
> 
> 
> Diffs
> -----
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java
>  784023b 
> 
> 
> Diff: https://reviews.apache.org/r/60134/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zsombor Gegesy
> 
>

Reply via email to