----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61025/#review183423 -----------------------------------------------------------
Ship it! Ship It! - Velmurugan Periasamy On July 21, 2017, 12:33 p.m., Ankita Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61025/ > ----------------------------------------------------------- > > (Updated July 21, 2017, 12:33 p.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1705 > https://issues.apache.org/jira/browse/RANGER-1705 > > > Repository: ranger > > > Description > ------- > > Good coding practice in Ranger recommended by static code analysis on > 1. TestRangerKeyStore.java > 2. TestServiceREST.java > 3. RangerSSOAuthenticationFilter.java > > > Diffs > ----- > > kms/src/test/java/org/apache/hadoop/crypto/key/kms/TestRangerKeyStore.java > c1925f8 > > security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java > b912e7e > security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java > 4bb0746 > > > Diff: https://reviews.apache.org/r/61025/diff/1/ > > > Testing > ------- > > 1. Tested SSO Authentication > 2. Junit test was successful > > > Thanks, > > Ankita Sinha > >
