Contributors/Committers,
Please review and fix as appropriate.
Thanks!
-Abhay
On 9/28/17, 12:43 AM, "scan-ad...@coverity.com" <scan-ad...@coverity.com>
wrote:
>
>Hi,
>
>Please find the latest report on new defect(s) introduced to Apache
>Ranger found with Coverity Scan.
>
>1 new defect(s) introduced to Apache Ranger found with Coverity Scan.
>6 defect(s), reported by Coverity Scan earlier, were marked fixed in the
>recent build analyzed by Coverity Scan.
>
>New defect(s) Reported-by: Coverity Scan
>Showing 1 of 1 defect(s)
>
>
>** CID 95505: (FORWARD_NULL)
>/security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java: 391 in
>org.apache.ranger.biz.XUserMgr.updateXUser(org.apache.ranger.view.VXUser)(
>)
>/security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java: 450 in
>org.apache.ranger.biz.XUserMgr.updateXUser(org.apache.ranger.view.VXUser)(
>)
>
>
>__________________________________________________________________________
>______________________________
>*** CID 95505: (FORWARD_NULL)
>/security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java: 391 in
>org.apache.ranger.biz.XUserMgr.updateXUser(org.apache.ranger.view.VXUser)(
>)
>385 if (oldUserProfile != null && password != null
>386 &&
>password.equals(hiddenPasswordString)) {
>387
>vXPortalUser.setPassword(oldUserProfile.getPassword());
>388 }
>389 else if(password != null){
>390 validatePassword(vXUser);
>>>> CID 95505: (FORWARD_NULL)
>>>> Calling a method on null object "oldUserProfile".
>391 if (oldUserProfile.getUserSource() ==
>RangerCommonEnums.USER_EXTERNAL) {
>392
>vXPortalUser.setPassword(oldUserProfile.getPassword());
>393 }
>394 else if(oldUserProfile.getUserSource() ==
>RangerCommonEnums.USER_APP)
>395 {
>396 vXPortalUser.setPassword(password);
>/security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java: 450 in
>org.apache.ranger.biz.XUserMgr.updateXUser(org.apache.ranger.view.VXUser)(
>)
>444 }
>445
>446 // TODO I've to get the transaction log from here.
>447 // There is nothing to log anything in XXUser so far.
>448 vXUser = xUserService.updateResource(vXUser);
>449 vXUser.setUserRoleList(roleList);
>>>> CID 95505: (FORWARD_NULL)
>>>> Calling a method on null object "oldUserProfile".
>450 if (oldUserProfile.getUserSource() ==
>RangerCommonEnums.USER_APP) {
>451 vXUser.setPassword(password);
>452 }
>453 else if (oldUserProfile.getUserSource() ==
>RangerCommonEnums.USER_EXTERNAL) {
>454 vXUser.setPassword(oldUserProfile.getPassword());
>455 }
>
>
>__________________________________________________________________________
>______________________________
>To view the defects in Coverity Scan visit,
>https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V
>05UPxvVjWch-2Bd2MGckcRZSbhom32dlDl11LWEm9nX11zsOWMf5dv3Q9Mogo-2FGua3FsLRTF
>ft2V-2FOFC9o0P2e0-3D_eYGgfjRVvnymu7-2Fg39LOcg-2Fwh01uR5A1l1-2BVcR3oH7qLxXG
>asFbgN1kDBPIpGYM3rLSYzmeG-2BYa7G8XDIAVjfLvpuAxZDAekPb7Ge-2BSV0V3UOxGH6fq7t
>e-2FBz9K3J-2BgMSVG-2FL-2B3b8wmTbrE5RlAh1Wx7Yj2PrpxopzDpFQBM6X-2BEGeMejc-2B
>gFYqieFfxz45obau1ECnoL6Zgv3JRtmS4o-2FC5Jl5P5hM89piOfkcF6zo-3D
>
>To manage Coverity Scan email notifications for
>"akulka...@hortonworks.com", click
>https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V
>05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4rq896qxTW4IjcOjjCxcjhdwy7bkx
>0GaYF4jcZRTENcC8UedPeL4l2t0VBzV197ihjH14Ve5jAkEZTKufdAcDuKGDIx74O-2BWzK0Pb
>pXpwQLY-3D_eYGgfjRVvnymu7-2Fg39LOcg-2Fwh01uR5A1l1-2BVcR3oH7qLxXGasFbgN1kDB
>PIpGYM3rLSYzmeG-2BYa7G8XDIAVjfHlwaVB9Raguih-2FwkcLjJA0mCtUkkDoj8F4HwxV4ZpC
>D-2FQeY7ix0A8aSjSvg-2FysIlBGXiCWYBVwryh4hjK562Q20-2BIvhXOzSXbKxEVV5aZLnfzJ
>KG64wXkL21sShFYAI7NY6s7J5F6xWpOzCARUum7g-3D
>
