Please review and fix if required. Thanks
Bosco On 11/12/17, 2:06 AM, "scan-ad...@coverity.com" <scan-ad...@coverity.com> wrote: Hi, Please find the latest report on new defect(s) introduced to Apache Ranger found with Coverity Scan. 5 new defect(s) introduced to Apache Ranger found with Coverity Scan. 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 5 of 5 defect(s) ** CID 168929: FindBugs: Internationalization (FB.DM_DEFAULT_ENCODING) /agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyDb.java: 96 in org.apache.ranger.plugin.policyengine.TestPolicyDb.runTestsFromResourceFiles(java.lang.String[], org.apache.ranger.plugin.model.RangerServiceDef)() ________________________________________________________________________________________________________ *** CID 168929: FindBugs: Internationalization (FB.DM_DEFAULT_ENCODING) /agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyDb.java: 96 in org.apache.ranger.plugin.policyengine.TestPolicyDb.runTestsFromResourceFiles(java.lang.String[], org.apache.ranger.plugin.model.RangerServiceDef)() 90 runTestsFromResourceFiles(hiveTestResourceFiles, hiveServiceDef); 91 } 92 93 private void runTestsFromResourceFiles(String[] resourceNames, RangerServiceDef serviceDef) { 94 for(String resourceName : resourceNames) { 95 InputStream inStream = this.getClass().getResourceAsStream(resourceName); >>> CID 168929: FindBugs: Internationalization (FB.DM_DEFAULT_ENCODING) >>> Found reliance on default encoding: new java.io.InputStreamReader(InputStream). 96 InputStreamReader reader = new InputStreamReader(inStream); 97 98 runTests(reader, resourceName, serviceDef); 99 } 100 } 101 ** CID 168928: FindBugs: Internationalization (FB.DM_DEFAULT_ENCODING) /agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/TestDefaultPolicyResourceMatcher.java: 109 in org.apache.ranger.plugin.resourcematcher.TestDefaultPolicyResourceMatcher.runTestsFromResourceFiles(java.lang.String[], org.apache.ranger.plugin.model.RangerServiceDef)() ________________________________________________________________________________________________________ *** CID 168928: FindBugs: Internationalization (FB.DM_DEFAULT_ENCODING) /agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/TestDefaultPolicyResourceMatcher.java: 109 in org.apache.ranger.plugin.resourcematcher.TestDefaultPolicyResourceMatcher.runTestsFromResourceFiles(java.lang.String[], org.apache.ranger.plugin.model.RangerServiceDef)() 103 runTestsFromResourceFiles(tests, hiveServiceDef); 104 } 105 106 private void runTestsFromResourceFiles(String[] resourceNames, RangerServiceDef serviceDef) throws Exception { 107 for (String resourceName : resourceNames) { 108 InputStream inStream = this.getClass().getResourceAsStream(resourceName); >>> CID 168928: FindBugs: Internationalization (FB.DM_DEFAULT_ENCODING) >>> Found reliance on default encoding: new java.io.InputStreamReader(InputStream). 109 InputStreamReader reader = new InputStreamReader(inStream); 110 111 runTests(reader, serviceDef); 112 } 113 } 114 ** CID 168927: FindBugs: Internationalization (FB.DM_DEFAULT_ENCODING) /agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/TestDefaultPolicyResourceMatcher.java: 76 in org.apache.ranger.plugin.resourcematcher.TestDefaultPolicyResourceMatcher.readServiceDef(java.lang.String)() ________________________________________________________________________________________________________ *** CID 168927: FindBugs: Internationalization (FB.DM_DEFAULT_ENCODING) /agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/TestDefaultPolicyResourceMatcher.java: 76 in org.apache.ranger.plugin.resourcematcher.TestDefaultPolicyResourceMatcher.readServiceDef(java.lang.String)() 70 hbaseServiceDef = readServiceDef("hbase"); 71 tagServiceDef = readServiceDef("tag"); 72 } 73 74 private static RangerServiceDef readServiceDef(String name) { 75 InputStream inStream = TestDefaultPolicyResourceMatcher.class.getResourceAsStream("/admin/service-defs/test-" + name + "-servicedef.json"); >>> CID 168927: FindBugs: Internationalization (FB.DM_DEFAULT_ENCODING) >>> Found reliance on default encoding: new java.io.InputStreamReader(InputStream). 76 InputStreamReader reader = new InputStreamReader(inStream); 77 return gsonBuilder.fromJson(reader, RangerServiceDef.class); 78 } 79 80 @AfterClass 81 public static void tearDownAfterClass() throws Exception { ** CID 168926: FindBugs: Internationalization (FB.DM_DEFAULT_ENCODING) /agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyDb.java: 69 in org.apache.ranger.plugin.policyengine.TestPolicyDb.readServiceDef(java.lang.String)() ________________________________________________________________________________________________________ *** CID 168926: FindBugs: Internationalization (FB.DM_DEFAULT_ENCODING) /agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyDb.java: 69 in org.apache.ranger.plugin.policyengine.TestPolicyDb.readServiceDef(java.lang.String)() 63 hbaseServiceDef = readServiceDef("hbase"); 64 tagServiceDef = readServiceDef("tag"); 65 } 66 67 private static RangerServiceDef readServiceDef(String name) { 68 InputStream inStream = TestPolicyDb.class.getResourceAsStream("/admin/service-defs/test-" + name + "-servicedef.json"); >>> CID 168926: FindBugs: Internationalization (FB.DM_DEFAULT_ENCODING) >>> Found reliance on default encoding: new java.io.InputStreamReader(InputStream). 69 InputStreamReader reader = new InputStreamReader(inStream); 70 return gsonBuilder.fromJson(reader, RangerServiceDef.class); 71 72 } 73 74 @AfterClass ** CID 168925: FindBugs: Internationalization (FB.DM_DEFAULT_ENCODING) /agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/TestDefaultPolicyResourceMatcherForPolicy.java: 78 in org.apache.ranger.plugin.resourcematcher.TestDefaultPolicyResourceMatcherForPolicy.readServiceDef(java.lang.String)() ________________________________________________________________________________________________________ *** CID 168925: FindBugs: Internationalization (FB.DM_DEFAULT_ENCODING) /agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/TestDefaultPolicyResourceMatcherForPolicy.java: 78 in org.apache.ranger.plugin.resourcematcher.TestDefaultPolicyResourceMatcherForPolicy.readServiceDef(java.lang.String)() 72 hbaseServiceDef = readServiceDef("hbase"); 73 tagServiceDef = readServiceDef("tag"); 74 } 75 76 private static RangerServiceDef readServiceDef(String name) { 77 InputStream inStream = TestDefaultPolicyResourceMatcherForPolicy.class.getResourceAsStream("/admin/service-defs/test-" + name + "-servicedef.json"); >>> CID 168925: FindBugs: Internationalization (FB.DM_DEFAULT_ENCODING) >>> Found reliance on default encoding: new java.io.InputStreamReader(InputStream). 78 InputStreamReader reader = new InputStreamReader(inStream); 79 return gsonBuilder.fromJson(reader, RangerServiceDef.class); 80 } 81 82 @AfterClass 83 public static void tearDownAfterClass() throws Exception { ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZSbhom32dlDl11LWEm9nX11zsOWMf5dv3Q9Mogo-2FGua3FsLRTFft2V-2FOFC9o0P2e0-3D_d04ZgyDzSjlwpjXIuOFYDNE6R93Lal83MDClQK32PZt64kww50kU1q-2F4VVb3XwtwtsxPSlvS1YaEcT3NKpQG22CT1rqf9HGRgfdXHG6yXwOBiiZbB0Hu7tzmRcaQN5hJMzgFeonLJfrNZxLVn7meMZfZJpRfnBbXOSqqn5-2FUoL-2Boews2rlbspIncegFpcT5R0YhrMUy0WzpxrXakfnGZPQ-3D-3D To manage Coverity Scan email notifications for "bo...@apache.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4HK0JLY-2BbZ-2FD0yvjg-2BbWSwquqqdEYtbR9nIDW-2BM81kI8TiABM2LsH3tiPfMWf-2FvOsjZSWngS5IRVC-2FH5Pl4zyaK1OE6Dh-2BhR6pXASEFJKZLM-3D_d04ZgyDzSjlwpjXIuOFYDNE6R93Lal83MDClQK32PZt64kww50kU1q-2F4VVb3XwtwUdY2uDkeXu0O-2Bhy5qLNk9ecc-2Fgcas6Op24L5bH8m0YzVHy2afk5jX1HNAanD-2BNW1aJw-2FcKgcJ4U2InGRhViR37dtTL0LYB5N2w37LAgT-2Bdf95hNiMvoap3USpa3N-2FtqBlpC9D8jXAPQycA8hX4prNw-3D-3D