----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62850/#review187462 -----------------------------------------------------------
Fix it, then Ship it! agents-common/src/main/java/org/apache/ranger/plugin/util/PerfDataRecorder.java Line 88 (original), 90 (patched) <https://reviews.apache.org/r/62850/#comment264458> May be good to include "(microsec)" ranger-tools/src/main/java/org/apache/ranger/policyengine/perftest/v2/RangerPolicyFactory.java Lines 62 (patched) <https://reviews.apache.org/r/62850/#comment264457> Please add JavaDoc to all new classes and important methods - Alejandro Fernandez On Oct. 9, 2017, 9:19 p.m., Endre Zoltan Kovacs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62850/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2017, 9:19 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1827 > https://issues.apache.org/jira/browse/RANGER-1827 > > > Repository: ranger > > > Description > ------- > > created a microbenchmark for the policy evaluation engine > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/util/PerfDataRecorder.java > 25f533476 > > ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestClient.java > e6095cba2 > > ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerAccessRequestDeserializer.java > PRE-CREATION > > ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerResourceDeserializer.java > PRE-CREATION > > ranger-tools/src/main/java/org/apache/ranger/policyengine/perftest/v2/RangerPolicyFactory.java > PRE-CREATION > > ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java > PRE-CREATION > ranger-tools/src/test/resources/log4j.properties 4ea9d854e > ranger-tools/src/test/resources/testdata/single-policy-template.json > PRE-CREATION > ranger-tools/src/test/resources/testdata/single-request-template.json > PRE-CREATION > > > Diff: https://reviews.apache.org/r/62850/diff/1/ > > > Testing > ------- > > A parameterized JUnit test that tests the performance of RangerPolicyEngine > under increasing load of number of policies and concurrent calls. > a cross product of the input parameters are generated and fed into the test > method. > > This microbenchmark includes a warm-up phase so that any of the JIT > performance optimizations happen before the measurement of the policy > engine's performance. > > > Thanks, > > Endre Zoltan Kovacs > >
