-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62850/
-----------------------------------------------------------

(Updated Oct. 10, 2017, 11:24 a.m.)


Review request for ranger.


Changes
-------

fixed issues:
- added microsec to log message
- added javadocs to classes and public methods
- excluding benchmark from tests run during maven build of the project (can 
still execute it manually with cd ranger-tools && mvn clean test 
-Dtest=RangerPolicyEnginePerformanceTest)
- formatting problems
- added generated .csv file to .gitignore


Bugs: RANGER-1827
    https://issues.apache.org/jira/browse/RANGER-1827


Repository: ranger


Description
-------

created a microbenchmark for the policy evaluation engine


Diffs (updated)
-----

  
agents-common/src/main/java/org/apache/ranger/plugin/util/PerfDataRecorder.java 
25f533476 
  ranger-tools/.gitignore 5ac84b1c9 
  ranger-tools/pom.xml ff37fb3eb 
  ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestClient.java 
e6095cba2 
  
ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerAccessRequestDeserializer.java
 PRE-CREATION 
  
ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerResourceDeserializer.java
 PRE-CREATION 
  
ranger-tools/src/main/java/org/apache/ranger/policyengine/perftest/v2/RangerPolicyFactory.java
 PRE-CREATION 
  
ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java
 PRE-CREATION 
  ranger-tools/src/test/resources/log4j.properties 4ea9d854e 
  ranger-tools/src/test/resources/testdata/single-policy-template.json 
PRE-CREATION 
  ranger-tools/src/test/resources/testdata/single-request-template.json 
PRE-CREATION 


Diff: https://reviews.apache.org/r/62850/diff/2/

Changes: https://reviews.apache.org/r/62850/diff/1-2/


Testing
-------

A parameterized JUnit test that tests the performance of RangerPolicyEngine 
under increasing load of number of policies and concurrent calls.
a cross product of the input parameters are generated and fed into the test 
method.

This microbenchmark includes a warm-up phase so that any of the JIT performance 
optimizations happen before the measurement of the policy engine's performance.


File Attachments (updated)
----------------

0001-RANGER-1827-microbenchmark-for-RangerPolicyEngine.patch
  
https://reviews.apache.org/media/uploaded/files/2017/10/10/3fc881bb-c8ea-427b-a6b4-8d1236159c82__0001-RANGER-1827-microbenchmark-for-RangerPolicyEngine.patch


Thanks,

Endre Zoltan Kovacs

Reply via email to