Mostly seems to be test code. Still please review… Thanks
Bosco > Begin forwarded message: > > From: scan-ad...@coverity.com > Subject: New Defects reported by Coverity Scan for Apache Ranger > Date: June 24, 2018 at 2:34:29 AM PDT > To: bo...@apache.org > > Hi, > > Please find the latest report on new defect(s) introduced to Apache Ranger > found with Coverity Scan. > > 20 new defect(s) introduced to Apache Ranger found with Coverity Scan. > 6 defect(s), reported by Coverity Scan earlier, were marked fixed in the > recent build analyzed by Coverity Scan. > > New defect(s) Reported-by: Coverity Scan > Showing 20 of 20 defect(s) > > > ** CID 154572: FindBugs: Bad practice (FB.DE_MIGHT_IGNORE) > /tagsync/src/test/java/org/apache/ranger/tagsync/process/TestHbaseResourceMapper.java: > 144 in > org.apache.ranger.tagsync.process.TestHbaseResourceMapper.testHbaseResourceFromMissingColumnFamilyName()() > > > ________________________________________________________________________________________________________ > *** CID 154572: FindBugs: Bad practice (FB.DE_MIGHT_IGNORE) > /tagsync/src/test/java/org/apache/ranger/tagsync/process/TestHbaseResourceMapper.java: > 144 in > org.apache.ranger.tagsync.process.TestHbaseResourceMapper.testHbaseResourceFromMissingColumnFamilyName()() > 138 RangerAtlasEntity entity = > getHbaseColumnFamilyEntity(entAttribs); > 139 > 140 try { > 141 RangerServiceResource resource = > resourceMapper.buildResource(entity); > 142 > 143 Assert.fail("expected exception. Found " + resource); >>>> CID 154572: FindBugs: Bad practice (FB.DE_MIGHT_IGNORE) >>>> >>>> org.apache.ranger.tagsync.process.TestHbaseResourceMapper.testHbaseResourceFromMissingColumnFamilyName() >>>> might ignore java.lang.Exception. > 144 } catch(Exception excp) { > 145 // ignore > 146 } > 147 } > 148 > 149 @Test > > ** CID 153272: FindBugs: Bad practice (FB.DE_MIGHT_IGNORE) > /tagsync/src/test/java/org/apache/ranger/tagsync/process/TestHdfsResourceMapper.java: > 155 in > org.apache.ranger.tagsync.process.TestHdfsResourceMapper.testHdfsResourceFromMissingAttribs()() > > > ________________________________________________________________________________________________________ > *** CID 153272: FindBugs: Bad practice (FB.DE_MIGHT_IGNORE) > /tagsync/src/test/java/org/apache/ranger/tagsync/process/TestHdfsResourceMapper.java: > 155 in > org.apache.ranger.tagsync.process.TestHdfsResourceMapper.testHdfsResourceFromMissingAttribs()() > 149 RangerAtlasEntity entity = > getHdfsPathEntity(entAttribs); > 150 > 151 try { > 152 RangerServiceResource resource = > resourceMapper.buildResource(entity); > 153 > 154 Assert.fail("expected exception. Found " + > resource); >>>> CID 153272: FindBugs: Bad practice (FB.DE_MIGHT_IGNORE) >>>> >>>> org.apache.ranger.tagsync.process.TestHdfsResourceMapper.testHdfsResourceFromMissingAttribs() >>>> might ignore java.lang.Exception. > 155 } catch(Exception excp) { > 156 // ignore > 157 } > 158 } > 159 > 160 @Test > > ** CID 153259: FindBugs: Bad practice (FB.DE_MIGHT_IGNORE) > /tagsync/src/test/java/org/apache/ranger/tagsync/process/TestHiveResourceMapper.java: > 91 in > org.apache.ranger.tagsync.process.TestHiveResourceMapper.testHiveResourceFromMissingAttribs()() > > > ________________________________________________________________________________________________________ > *** CID 153259: FindBugs: Bad practice (FB.DE_MIGHT_IGNORE) > /tagsync/src/test/java/org/apache/ranger/tagsync/process/TestHiveResourceMapper.java: > 91 in > org.apache.ranger.tagsync.process.TestHiveResourceMapper.testHiveResourceFromMissingAttribs()() > 85 RangerAtlasEntity entity = getHiveDbEntity(entAttribs); > 86 > 87 try { > 88 RangerServiceResource resource = > resourceMapper.buildResource(entity); > 89 > 90 Assert.fail("expected exception. Found " + > resource); >>>> CID 153259: FindBugs: Bad practice (FB.DE_MIGHT_IGNORE) >>>> >>>> org.apache.ranger.tagsync.process.TestHiveResourceMapper.testHiveResourceFromMissingAttribs() >>>> might ignore java.lang.Exception. > 91 } catch(Exception excp) { > 92 // ignore > 93 } > 94 } > 95 > 96 private RangerAtlasEntity getHiveDbEntity(Map<String, Object> > entAttribs) throws Exception { > > ** CID 150695: FindBugs: Internationalization (FB.DM_DEFAULT_ENCODING) > /ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerPluginPerfTester.java: > 145 in > org.apache.ranger.policyengine.RangerPluginPerfTester.buildConfigurationFile()() > > > ________________________________________________________________________________________________________ > *** CID 150695: FindBugs: Internationalization (FB.DM_DEFAULT_ENCODING) > /ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerPluginPerfTester.java: > 145 in > org.apache.ranger.policyengine.RangerPluginPerfTester.buildConfigurationFile()() > 139 Path filePath = new Path(filePathStr); > 140 > 141 FileSystem fs = filePath.getFileSystem(new > Configuration()); > 142 > 143 FSDataOutputStream outStream = > fs.create(filePath, true); > 144 >>>> CID 150695: FindBugs: Internationalization (FB.DM_DEFAULT_ENCODING) >>>> Found reliance on default encoding: new >>>> java.io.OutputStreamWriter(OutputStream). > 145 OutputStreamWriter writer = new > OutputStreamWriter(outStream); > 146 > 147 writer.write("<configuration>\n" + > 148 " <property>\n" + > 149 " <name>" + > propertyPrefix + ".policy.pollIntervalMs</name>\n" + > 150 " <value>" + > pollingInterval + "</value>\n" + > > ** CID 133758: FindBugs: Dodgy code (FB.REC_CATCH_EXCEPTION) > /ranger-tools/src/test/java/org/apache/ranger/policyengine/PerfTesterTest.java: > 84 in org.apache.ranger.policyengine.PerfTesterTest.readCommandLine()() > > > ________________________________________________________________________________________________________ > *** CID 133758: FindBugs: Dodgy code (FB.REC_CATCH_EXCEPTION) > /ranger-tools/src/test/java/org/apache/ranger/policyengine/PerfTesterTest.java: > 84 in org.apache.ranger.policyengine.PerfTesterTest.readCommandLine()() > 78 if (!line.isEmpty() && !line.startsWith("#")) { > 79 ret = line.split(" "); > 80 break; > 81 } > 82 } > 83 >>>> CID 133758: FindBugs: Dodgy code (FB.REC_CATCH_EXCEPTION) >>>> Catching RuntimeExceptions, perhaps unintentionally, with a catch block >>>> for Exception. > 84 } catch (Exception exception) { > 85 System.out.println("Error reading arguments:" + > exception); > 86 } > 87 } > 88 return ret; > 89 } > 90 > > ** CID 131848: FindBugs: Internationalization (FB.DM_DEFAULT_ENCODING) > /tagsync/src/test/java/org/apache/ranger/tagsync/process/TestTagSynchronizer.java: > 41 in > org.apache.ranger.tagsync.process.TestTagSynchronizer.setUpBeforeClass()() > > > ________________________________________________________________________________________________________ > *** CID 131848: FindBugs: Internationalization (FB.DM_DEFAULT_ENCODING) > /tagsync/src/test/java/org/apache/ranger/tagsync/process/TestTagSynchronizer.java: > 41 in > org.apache.ranger.tagsync.process.TestTagSynchronizer.setUpBeforeClass()() > 35 @BeforeClass > 36 public static void setUpBeforeClass() throws Exception { > 37 System.out.println("setUpBeforeClass() called"); > 38 > 39 TagSyncConfig config = TagSyncConfig.getInstance(); > 40 >>>> CID 131848: FindBugs: Internationalization (FB.DM_DEFAULT_ENCODING) >>>> Found reliance on default encoding: new >>>> java.io.OutputStreamWriter(OutputStream). > 41 TagSyncConfig.dumpConfiguration(config, new > BufferedWriter(new OutputStreamWriter(System.out))); > 42 System.out.println(); > 43 > 44 Properties props = config.getProperties(); > 45 > 46 tagSynchronizer = new TagSynchronizer(props); > > ** CID 175981: Incorrect expression (USELESS_CALL) > > > ________________________________________________________________________________________________________ > *** CID 175981: Incorrect expression (USELESS_CALL) > /security-admin/src/test/java/org/apache/ranger/service/TestAuthSessionService.java: > 67 in > org.apache.ranger.service.TestAuthSessionService.test1GetResourceName()() > 61 > 62 @Mock > 63 BaseDao entityDao; > 64 > 65 @Test > 66 public void test1GetResourceName() { >>>> CID 175981: Incorrect expression (USELESS_CALL) >>>> Calling "authSessionService.getResourceName()" is only useful for its >>>> return value, which is ignored. > 67 authSessionService.getResourceName(); > 68 } > 69 > 70 @Test > 71 public void test2CreateEntityObject() { > 72 authSessionService.createEntityObject(); > > ** CID 175980: FindBugs: Performance (FB.URF_UNREAD_FIELD) > /security-admin/src/test/java/org/apache/ranger/service/TestRangerPluginActivityLogger.java: > 47 in () > > > ________________________________________________________________________________________________________ > *** CID 175980: FindBugs: Performance (FB.URF_UNREAD_FIELD) > /security-admin/src/test/java/org/apache/ranger/service/TestRangerPluginActivityLogger.java: > 47 in () > 41 @Mock > 42 RangerTransactionService transactionService; > 43 > 44 @Mock > 45 Runnable commitWork; > 46 >>>> CID 175980: FindBugs: Performance (FB.URF_UNREAD_FIELD) >>>> Unread field: >>>> org.apache.ranger.service.TestRangerPluginActivityLogger.pluginActivityAuditCommitInline. > 47 boolean pluginActivityAuditCommitInline = false; > 48 > 49 @Test > 50 public void test1CommitAfterTransactionComplete() { > 51 pluginActivityAuditCommitInline = false; > 52 > rangerPluginActivityLogger.commitAfterTransactionComplete(commitWork); > > ** CID 175979: Incorrect expression (USELESS_CALL) > > > ________________________________________________________________________________________________________ > *** CID 175979: Incorrect expression (USELESS_CALL) > /security-admin/src/test/java/org/apache/ranger/service/TestAuthSessionService.java: > 77 in > org.apache.ranger.service.TestAuthSessionService.test3CreateViewObject()() > 71 public void test2CreateEntityObject() { > 72 authSessionService.createEntityObject(); > 73 } > 74 > 75 @Test > 76 public void test3CreateViewObject() { >>>> CID 175979: Incorrect expression (USELESS_CALL) >>>> Calling "authSessionService.createViewObject()" is only useful for its >>>> return value, which is ignored. > 77 authSessionService.createViewObject(); > 78 } > 79 > 80 @Test > 81 public void test4search() { > 82 SearchCriteria testSearchCriteria = > createsearchCriteria(); > > ** CID 174643: FindBugs: Performance (FB.SIC_INNER_SHOULD_BE_STATIC) > /plugin-atlas/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java: > 315 in () > > > ________________________________________________________________________________________________________ > *** CID 174643: FindBugs: Performance (FB.SIC_INNER_SHOULD_BE_STATIC) > /plugin-atlas/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java: > 315 in () > 309 class RangerAtlasPlugin extends RangerBasePlugin { > 310 RangerAtlasPlugin() { > 311 super("atlas", "atlas"); > 312 } > 313 } > 314 >>>> CID 174643: FindBugs: Performance (FB.SIC_INNER_SHOULD_BE_STATIC) >>>> Should >>>> org.apache.ranger.authorization.atlas.authorizer.RangerAtlasAuthorizer$RangerAtlasAuditHandler >>>> be a _static_ inner class? > 315 class RangerAtlasAuditHandler extends RangerDefaultAuditHandler { > 316 private final Map<String, AuthzAuditEvent> auditEvents; > 317 private final String resourcePath; > 318 private boolean denyExists = false; > 319 > 320 public RangerAtlasAuditHandler(AtlasEntityAccessRequest > request, RangerServiceDef serviceDef) { > > ** CID 171971: FindBugs: Dodgy code > (FB.NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE) > /ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java: > 107 in > org.apache.ranger.policyengine.RangerPolicyEnginePerformanceTest$1.apply(java.util.List)() > > > ________________________________________________________________________________________________________ > *** CID 171971: FindBugs: Dodgy code > (FB.NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE) > /ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java: > 107 in > org.apache.ranger.policyengine.RangerPolicyEnginePerformanceTest$1.apply(java.util.List)() > 101 // tree set for maintaining natural ordering > 102 Set<Integer> policies = > Sets.newTreeSet(Lists.newArrayList(5, 50, 100, 250, 500, 1_000, 2_000, 3_000, > 4_000, 5_000)); > 103 Set<Integer> concurrency = > Sets.newTreeSet(Lists.newArrayList(1, 5, 10, 20, 30, 40, 50, 100)); > 104 > 105 return > Iterables.transform(Sets.cartesianProduct(policies, concurrency), new > Function<List<Integer>, Object[]>() { > 106 @Override >>>> CID 171971: FindBugs: Dodgy code >>>> (FB.NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE) >>>> input must be nonnull but is marked as nullable. > 107 public Object[] apply(List<Integer> input) { > 108 return input.toArray(); > 109 } > 110 }); > 111 } > 112 > > ** CID 171970: (FB.UWF_UNWRITTEN_FIELD) > /tagsync/src/test/java/org/apache/ranger/tagsync/process/TestHbaseResourceMapper.java: > 274 in () > /tagsync/src/test/java/org/apache/ranger/tagsync/process/TestHbaseResourceMapper.java: > 274 in () > > > ________________________________________________________________________________________________________ > *** CID 171970: (FB.UWF_UNWRITTEN_FIELD) > /tagsync/src/test/java/org/apache/ranger/tagsync/process/TestHbaseResourceMapper.java: > 274 in () > 268 > 269 Assert.assertEquals(1, resource.getResourceElements().size()); > 270 > 271 > Assert.assertTrue(resource.getResourceElements().containsKey(AtlasHbaseResourceMapper.RANGER_TYPE_HBASE_TABLE)); > 272 > Assert.assertNotNull(resource.getResourceElements().get(AtlasHbaseResourceMapper.RANGER_TYPE_HBASE_TABLE).getValues()); > 273 Assert.assertEquals(1, > resource.getResourceElements().get(AtlasHbaseResourceMapper.RANGER_TYPE_HBASE_TABLE).getValues().size()); >>>> CID 171970: (FB.UWF_UNWRITTEN_FIELD) >>>> Unwritten field: >>>> org.apache.ranger.tagsync.process.TestHbaseResourceMapper.DOTTED_RANGER_TABLE. > 274 Assert.assertEquals(isDottedTable ? DOTTED_RANGER_TABLE : > RANGER_TABLE, > resource.getResourceElements().get(AtlasHbaseResourceMapper.RANGER_TYPE_HBASE_TABLE).getValues().get(0)); > 275 } > 276 > 277 private void assertColumnFamilyResource(RangerServiceResource > resource, boolean isDottedTable) { > 278 assertServiceResource(resource); > 279 > /tagsync/src/test/java/org/apache/ranger/tagsync/process/TestHbaseResourceMapper.java: > 274 in () > 268 > 269 Assert.assertEquals(1, resource.getResourceElements().size()); > 270 > 271 > Assert.assertTrue(resource.getResourceElements().containsKey(AtlasHbaseResourceMapper.RANGER_TYPE_HBASE_TABLE)); > 272 > Assert.assertNotNull(resource.getResourceElements().get(AtlasHbaseResourceMapper.RANGER_TYPE_HBASE_TABLE).getValues()); > 273 Assert.assertEquals(1, > resource.getResourceElements().get(AtlasHbaseResourceMapper.RANGER_TYPE_HBASE_TABLE).getValues().size()); >>>> CID 171970: (FB.UWF_UNWRITTEN_FIELD) >>>> Unwritten field: >>>> org.apache.ranger.tagsync.process.TestHbaseResourceMapper.RANGER_TABLE. > 274 Assert.assertEquals(isDottedTable ? DOTTED_RANGER_TABLE : > RANGER_TABLE, > resource.getResourceElements().get(AtlasHbaseResourceMapper.RANGER_TYPE_HBASE_TABLE).getValues().get(0)); > 275 } > 276 > 277 private void assertColumnFamilyResource(RangerServiceResource > resource, boolean isDottedTable) { > 278 assertServiceResource(resource); > 279 > > ** CID 171969: FindBugs: Bad practice (FB.VA_FORMAT_STRING_USES_NEWLINE) > /ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java: > 139 in > org.apache.ranger.policyengine.RangerPolicyEnginePerformanceTest.after()() > > > ________________________________________________________________________________________________________ > *** CID 171969: FindBugs: Bad practice (FB.VA_FORMAT_STRING_USES_NEWLINE) > /ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java: > 139 in > org.apache.ranger.policyengine.RangerPolicyEnginePerformanceTest.after()() > 133 > 134 @After > 135 public void after() throws IOException { > 136 Map<String, PerfStatistic> exposeStatistics = > PerfDataRecorder.exposeStatistics(); > 137 PerfStatistic stat = > exposeStatistics.get(STATISTICS_KEY__ACCESS_ALLOWED); > 138 long average = stat.getNumberOfInvocations() > 0 ? > (stat.getMicroSecondsSpent() / stat.getNumberOfInvocations()) : 0; >>>> CID 171969: FindBugs: Bad practice (FB.VA_FORMAT_STRING_USES_NEWLINE) >>>> Format string should use %n rather than \n. > 139 Files.append(String.format("%s;%s;%s;%s;%s;%s;\n", > numberOfPolicies, concurrency, average, stat.getMinTimeSpent(), > stat.getMaxTimeSpent(), stat.getMicroSecondsSpent()), outputFile(), > Charsets.UTF_8); > 140 PerfDataRecorder.printStatistics(); > 141 PerfDataRecorder.clearStatistics(); > 142 } > 143 > 144 @Test > > ** CID 168820: FindBugs: Internationalization (FB.DM_DEFAULT_ENCODING) > /plugin-sqoop/src/test/java/org/apache/ranger/authorization/sqoop/authorizer/RangerAdminClientImpl.java: > 68 in > org.apache.ranger.authorization.sqoop.authorizer.RangerAdminClientImpl.getServicePoliciesIfUpdated(long, > long)() > > > ________________________________________________________________________________________________________ > *** CID 168820: FindBugs: Internationalization (FB.DM_DEFAULT_ENCODING) > /plugin-sqoop/src/test/java/org/apache/ranger/authorization/sqoop/authorizer/RangerAdminClientImpl.java: > 68 in > org.apache.ranger.authorization.sqoop.authorizer.RangerAdminClientImpl.getServicePoliciesIfUpdated(long, > long)() > 62 } > 63 > 64 java.nio.file.Path cachePath = FileSystems.getDefault() > 65 .getPath(basedir, > "/src/test/resources/" + cacheFilename); > 66 byte[] cacheBytes = Files.readAllBytes(cachePath); > 67 >>>> CID 168820: FindBugs: Internationalization (FB.DM_DEFAULT_ENCODING) >>>> Found reliance on default encoding: new String(byte[]). > 68 return gson.fromJson(new String(cacheBytes), > ServicePolicies.class); > 69 } > 70 > 71 @Override > 72 public void grantAccess(GrantRevokeRequest request) throws > Exception { > 73 > > ** CID 157027: FindBugs: Performance (FB.SIC_INNER_SHOULD_BE_STATIC) > /plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceOperationResponse.java: > 61 in () > > > ________________________________________________________________________________________________________ > *** CID 157027: FindBugs: Performance (FB.SIC_INNER_SHOULD_BE_STATIC) > /plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceOperationResponse.java: > 61 in () > 55 } > 56 > 57 public void setResults(List<Results> results) { > 58 this.results = results; > 59 } > 60 >>>> CID 157027: FindBugs: Performance (FB.SIC_INNER_SHOULD_BE_STATIC) >>>> Should >>>> org.apache.ranger.services.atlas.json.model.ResourceOperationResponse$Results >>>> be a _static_ inner class? > 61 public class Results { > 62 > 63 private String result; > 64 private String count; > 65 > 66 public String getResult() { > > ** CID 154577: FindBugs: Bad practice (FB.DE_MIGHT_IGNORE) > /tagsync/src/test/java/org/apache/ranger/tagsync/process/TestKafkaResourceMapper.java: > 67 in > org.apache.ranger.tagsync.process.TestKafkaResourceMapper.testKafkaResourceFromOnlyTopic()() > > > ________________________________________________________________________________________________________ > *** CID 154577: FindBugs: Bad practice (FB.DE_MIGHT_IGNORE) > /tagsync/src/test/java/org/apache/ranger/tagsync/process/TestKafkaResourceMapper.java: > 67 in > org.apache.ranger.tagsync.process.TestKafkaResourceMapper.testKafkaResourceFromOnlyTopic()() > 61 RangerAtlasEntity entity = getKafkaTopicEntity(entAttribs); > 62 > 63 try { > 64 RangerServiceResource resource = > resourceMapper.buildResource(entity); > 65 > 66 Assert.fail("expected exception. Found " + resource); >>>> CID 154577: FindBugs: Bad practice (FB.DE_MIGHT_IGNORE) >>>> >>>> org.apache.ranger.tagsync.process.TestKafkaResourceMapper.testKafkaResourceFromOnlyTopic() >>>> might ignore java.lang.Exception. > 67 } catch(Exception excp) { > 68 // ignore > 69 } > 70 } > 71 > 72 @Test > > ** CID 154576: FindBugs: Bad practice (FB.DE_MIGHT_IGNORE) > /tagsync/src/test/java/org/apache/ranger/tagsync/process/TestKafkaResourceMapper.java: > 84 in > org.apache.ranger.tagsync.process.TestKafkaResourceMapper.testKafkaResourceFromOnlyClusterName()() > > > ________________________________________________________________________________________________________ > *** CID 154576: FindBugs: Bad practice (FB.DE_MIGHT_IGNORE) > /tagsync/src/test/java/org/apache/ranger/tagsync/process/TestKafkaResourceMapper.java: > 84 in > org.apache.ranger.tagsync.process.TestKafkaResourceMapper.testKafkaResourceFromOnlyClusterName()() > 78 RangerAtlasEntity entity = getKafkaTopicEntity(entAttribs); > 79 > 80 try { > 81 RangerServiceResource resource = > resourceMapper.buildResource(entity); > 82 > 83 Assert.fail("expected exception. Found " + resource); >>>> CID 154576: FindBugs: Bad practice (FB.DE_MIGHT_IGNORE) >>>> >>>> org.apache.ranger.tagsync.process.TestKafkaResourceMapper.testKafkaResourceFromOnlyClusterName() >>>> might ignore java.lang.Exception. > 84 } catch(Exception excp) { > 85 // ignore > 86 } > 87 } > 88 > 89 @Test > > ** CID 154575: FindBugs: Bad practice (FB.DE_MIGHT_IGNORE) > /tagsync/src/test/java/org/apache/ranger/tagsync/process/TestKafkaResourceMapper.java: > 99 in > org.apache.ranger.tagsync.process.TestKafkaResourceMapper.testKafkaResourceFromMissingAttribs()() > > > ________________________________________________________________________________________________________ > *** CID 154575: FindBugs: Bad practice (FB.DE_MIGHT_IGNORE) > /tagsync/src/test/java/org/apache/ranger/tagsync/process/TestKafkaResourceMapper.java: > 99 in > org.apache.ranger.tagsync.process.TestKafkaResourceMapper.testKafkaResourceFromMissingAttribs()() > 93 RangerAtlasEntity entity = getKafkaTopicEntity(entAttribs); > 94 > 95 try { > 96 RangerServiceResource resource = > resourceMapper.buildResource(entity); > 97 > 98 Assert.fail("expected exception. Found " + resource); >>>> CID 154575: FindBugs: Bad practice (FB.DE_MIGHT_IGNORE) >>>> >>>> org.apache.ranger.tagsync.process.TestKafkaResourceMapper.testKafkaResourceFromMissingAttribs() >>>> might ignore java.lang.Exception. > 99 } catch(Exception excp) { > 100 // ignore > 101 } > 102 } > 103 > 104 private RangerAtlasEntity getKafkaTopicEntity(Map<String, Object> > entAttribs) throws Exception { > > ** CID 154574: FindBugs: Bad practice (FB.DE_MIGHT_IGNORE) > /tagsync/src/test/java/org/apache/ranger/tagsync/process/TestHbaseResourceMapper.java: > 127 in > org.apache.ranger.tagsync.process.TestHbaseResourceMapper.testHbaseResourceFromMissingAttribs()() > > > ________________________________________________________________________________________________________ > *** CID 154574: FindBugs: Bad practice (FB.DE_MIGHT_IGNORE) > /tagsync/src/test/java/org/apache/ranger/tagsync/process/TestHbaseResourceMapper.java: > 127 in > org.apache.ranger.tagsync.process.TestHbaseResourceMapper.testHbaseResourceFromMissingAttribs()() > 121 RangerAtlasEntity entity = getHbaseTableEntity(entAttribs); > 122 > 123 try { > 124 RangerServiceResource resource = > resourceMapper.buildResource(entity); > 125 > 126 Assert.fail("expected exception. Found " + resource); >>>> CID 154574: FindBugs: Bad practice (FB.DE_MIGHT_IGNORE) >>>> >>>> org.apache.ranger.tagsync.process.TestHbaseResourceMapper.testHbaseResourceFromMissingAttribs() >>>> might ignore java.lang.Exception. > 127 } catch(Exception excp) { > 128 // ignore > 129 } > 130 } > 131 > 132 @Test > > ** CID 154573: FindBugs: Bad practice (FB.DE_MIGHT_IGNORE) > /tagsync/src/test/java/org/apache/ranger/tagsync/process/TestHbaseResourceMapper.java: > 161 in > org.apache.ranger.tagsync.process.TestHbaseResourceMapper.testHbaseResourceFromMissingColumnName()() > > > ________________________________________________________________________________________________________ > *** CID 154573: FindBugs: Bad practice (FB.DE_MIGHT_IGNORE) > /tagsync/src/test/java/org/apache/ranger/tagsync/process/TestHbaseResourceMapper.java: > 161 in > org.apache.ranger.tagsync.process.TestHbaseResourceMapper.testHbaseResourceFromMissingColumnName()() > 155 RangerAtlasEntity entity = getHbaseColumnEntity(entAttribs); > 156 > 157 try { > 158 RangerServiceResource resource = > resourceMapper.buildResource(entity); > 159 > 160 Assert.fail("expected exception. Found " + resource); >>>> CID 154573: FindBugs: Bad practice (FB.DE_MIGHT_IGNORE) >>>> >>>> org.apache.ranger.tagsync.process.TestHbaseResourceMapper.testHbaseResourceFromMissingColumnName() >>>> might ignore java.lang.Exception. > 161 } catch(Exception excp) { > 162 // ignore > 163 } > 164 } > 165 > 166 @Test > > > ________________________________________________________________________________________________________ > To view the defects in Coverity Scan visit, > https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZSbhom32dlDl11LWEm9nX11zsOWMf5dv3Q9Mogo-2FGua3FsLRTFft2V-2FOFC9o0P2e0-3D_d04ZgyDzSjlwpjXIuOFYDNE6R93Lal83MDClQK32PZv2JBeDJ5EQ-2F6vJR8gBwOTsHkvWjRuK1HszqiwWnWTVxAPZtLp9D9SJAGQ4domCHklkuHEwFgvwuOH0Q8OmjqAZI8LGNsW13iEE3P5bm889RpH2RwrESPi-2BI4-2FuTE4v8XF-2F79Yfc-2F4j6Ce5okE8ajiDtYfA0Ls5NhmHFSASULZhxA-3D-3D > > To manage Coverity Scan email notifications for "bo...@apache.org", click > https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4HK0JLY-2BbZ-2FD0yvjg-2BbWSwquqqdEYtbR9nIDW-2BM81kI8TiABM2LsH3tiPfMWf-2FvOsjZSWngS5IRVC-2FH5Pl4zyaK1OE6Dh-2BhR6pXASEFJKZLM-3D_d04ZgyDzSjlwpjXIuOFYDNE6R93Lal83MDClQK32PZv2JBeDJ5EQ-2F6vJR8gBwOTsIZLg5TE1F-2FcVTISIikRpJlrId2WZhAI79v1qUaM9mCL6KRRgIrHWMGQ-2FJoz8KaBr6WrZVG2KY2hnSBVUBZh9GaPtJ1h2Lu-2BfsjUPlH2lfDpBwuRw1O2fQ5bS5101wegsA-2BSBCwUhaZJUgOJRbyXaBQ-3D-3D >